Fix hanging of query when the key in order is an array #43427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorna2152
requested review from
gimantha,
MaryamZi,
KavinduZoysa,
warunalakshitha,
azinneera,
sameerajayasoma and
hasithaa
as code owners
|
@poorna2152 Shall we add few test cases to oder by fields with type |
gimantha
reviewed
Sep 27, 2024
| @@ -502,3 +502,98 @@ function incrementCount(int i) returns int { | |||
| int count = i + 2; | |||
| return count; | |||
| } | |||
|
|
|||
| function testQueryExprWithOrderByClauseWithArrayKey() { | |||
| record {|int[] t; string s;|}[] data1 = [ | |||
There was a problem hiding this comment.
Lets add few more tests with record type and enum
There was a problem hiding this comment.
It is not possible to use a record type as a key in the order by clause since it is not a ordered-type. https://ballerina.io/spec/lang/master/#ordering
gimantha
added
the
Team/CompilerFE
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #43427 +/- ##
=========================================
Coverage ? 77.51%
Complexity ? 58594
=========================================
Files ? 3438
Lines ? 219234
Branches ? 28917
=========================================
Hits ? 169934
Misses ? 39880
Partials ? 9420 ☔ View full report in Codecov by Sentry. |
MaryamZi
reviewed
Sep 27, 2024
gimantha
approved these changes
Oct 2, 2024
|
@poorna2152 shall we send the same fix for 2201.10.x and 2201.9.x branch as well? |
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #43418
Approach
Samples
Remarks
Check List