Fix bal pack crashes when [[dependency]] section is missing in the CompilerPlugin.toml file #43426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpilerPlugin.toml file
Shadow-Devil
requested review from
sameerajayasoma,
hasithaa,
gimantha and
MaryamZi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #43426 +/- ##
=========================================
Coverage ? 77.53%
Complexity ? 58717
=========================================
Files ? 3447
Lines ? 219689
Branches ? 28937
=========================================
Hits ? 170335
Misses ? 39934
Partials ? 9420 ☔ View full report in Codecov by Sentry. |
gimantha
reviewed
Oct 4, 2024
| @@ -138,32 +138,28 @@ protected void addCompilerPlugin(ZipOutputStream balaOutputStream) throws IOExce | |||
| List<String> compilerPluginLibPaths = new ArrayList<>(); | |||
| List<String> compilerPluginDependencies = this.compilerPluginToml.get().getCompilerPluginDependencies(); | |||
|
|
|||
| if (compilerPluginDependencies.get(0) == null) { | |||
| if (compilerPluginDependencies.isEmpty()) { | |||
There was a problem hiding this comment.
@Shadow-Devil The fix is working fine now we get the below error message.
Shall we add a negative test case for this?
We have a few negative test cases in io.ballerina.projects.test.plugins.CompilerPluginNegativeTests. Can you please add one for this fix?
gimantha
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #41418 and #42120
Approach
Samples
Remarks
Check List