Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Step Extension] Add semantic support xml step extension #43106

Conversation

poorna2152
Copy link
Contributor

Purpose

$subject

Approach

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@poorna2152 poorna2152 marked this pull request as draft July 16, 2024 08:16
@poorna2152 poorna2152 marked this pull request as ready for review July 16, 2024 08:30
@poorna2152 poorna2152 marked this pull request as draft July 16, 2024 09:02
@poorna2152 poorna2152 marked this pull request as ready for review July 19, 2024 05:49
@poorna2152 poorna2152 force-pushed the xml_step_extend_method_invocation branch from ab2f29f to 1d1a38f Compare July 21, 2024 06:45
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 83.87097% with 55 lines in your changes missing coverage. Please review.

Project coverage is 77.36%. Comparing base (16ade74) to head (089ff59).
Report is 422 commits behind head on xml_step_extension.

Files with missing lines Patch % Lines
...inalang/compiler/tree/SimpleBLangNodeAnalyzer.java 0.00% 16 Missing ⚠️
.../expressions/BLangExtendedXMLNavigationAccess.java 58.82% 7 Missing ⚠️
...g/wso2/ballerinalang/compiler/desugar/Desugar.java 95.78% 2 Missing and 2 partials ⚠️
...lerinalang/compiler/tree/BLangNodeTransformer.java 0.00% 4 Missing ⚠️
.../ballerinalang/compiler/tree/BLangNodeVisitor.java 0.00% 4 Missing ⚠️
...ler/tree/expressions/BLangXMLFilterStepExtend.java 69.23% 4 Missing ⚠️
...ler/tree/expressions/BLangXMLNavigationAccess.java 20.00% 4 Missing ⚠️
...va/io/ballerina/compiler/api/impl/BaseVisitor.java 0.00% 3 Missing ⚠️
...ava/io/ballerina/compiler/api/impl/NodeFinder.java 70.00% 3 Missing ⚠️
...allerinalang/compiler/parser/BLangNodeBuilder.java 93.75% 1 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@                   Coverage Diff                   @@
##             xml_step_extension   #43106     +/-   ##
=======================================================
  Coverage                 77.35%   77.36%             
- Complexity                58300    58721    +421     
=======================================================
  Files                      3454     3469     +15     
  Lines                    219173   220382   +1209     
  Branches                  28741    28933    +192     
=======================================================
+ Hits                     169544   170491    +947     
- Misses                    40295    40472    +177     
- Partials                   9334     9419     +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Override
public void visit(BLangXMLFilterStepExtend xmlFilterStepExtend) {
lookupNodes(xmlFilterStepExtend.filters);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we check if we can fix the codecov warnings?

public void visit(BLangExtendedXMLNavigationAccess extendedXMLNavigationAccess) {
extendedXMLNavigationAccess.stepExpr = rewriteExpr(extendedXMLNavigationAccess.stepExpr);
result = extendedXMLNavigationAccess;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check codecov warnings everywhere.

@@ -2310,6 +2314,24 @@ public void visit(BLangXMLElementFilter source) {
source.cloneRef = clone;
}

@Override
public void visit(BLangXMLIndexedStepExtend source) {
BLangXMLIndexedStepExtend clone = new BLangXMLIndexedStepExtend(source.pos, source.indexExpr);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Index or member?

Copy link
Member

@heshanpadmasiri heshanpadmasiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit other than that LGTM

Copy link

github-actions bot commented Aug 7, 2024

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Aug 7, 2024
@poorna2152 poorna2152 removed the Stale label Aug 8, 2024
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@poorna2152 poorna2152 force-pushed the xml_step_extend_method_invocation branch 2 times, most recently from 6c6ff0e to a969212 Compare September 15, 2024 01:30
@poorna2152 poorna2152 force-pushed the xml_step_extend_method_invocation branch from a969212 to 5e9ee97 Compare September 17, 2024 10:38
@poorna2152 poorna2152 force-pushed the xml_step_extend_method_invocation branch from b2bb60f to 317e292 Compare September 19, 2024 08:20
@gimantha gimantha merged commit 0eb9e31 into ballerina-platform:xml_step_extension Oct 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants