Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Fix runtime invokeAsync API to call function block the calling Thread #43031

Merged

Conversation

warunalakshitha
Copy link
Contributor

Purpose

Fixes #42865
Fixes #42868

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 91.44737% with 13 lines in your changes missing coverage. Please review.

Project coverage is 77.38%. Comparing base (5ec8be9) to head (0989fe3).
Report is 30 commits behind head on master.

Files Patch % Lines
...java/io/ballerina/runtime/internal/BalRuntime.java 84.12% 9 Missing and 1 partial ⚠️
...rina/runtime/internal/scheduling/SyncCallback.java 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43031      +/-   ##
============================================
+ Coverage     77.35%   77.38%   +0.02%     
- Complexity    58251    58329      +78     
============================================
  Files          3450     3451       +1     
  Lines        218927   219277     +350     
  Branches      28728    28873     +145     
============================================
+ Hits         169359   169692     +333     
- Misses        40243    40267      +24     
+ Partials       9325     9318       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HindujaB HindujaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha merged commit 47293c1 into ballerina-platform:master Jul 19, 2024
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants