-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactoring] Mark fields as final if they are not reassigned #43028
Conversation
...ter-core/src/main/java/org/ballerinalang/formatter/core/options/IndentFormattingOptions.java
Outdated
Show resolved
Hide resolved
...s/testerina-integration-test/src/test/java/org/ballerinalang/testerina/utils/RuntimeApi.java
Outdated
Show resolved
Hide resolved
Other than #43028 (comment) LGTM |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
11a0d46
to
1f949b7
Compare
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
Closed PR due to inactivity for more than 18 days. |
@MaryamZi @SasinduDilshara it seems this PR got closed due to inactivity. So we might need to re-open this and continue reviewing? |
246a310
to
e7a87ac
Compare
Failing testcase in Ballerina Distribution:
This is not related to this PR since it also happened in #42955 |
e7a87ac
to
58b5700
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bindgen tool related changes LGTM
58b5700
to
465d1da
Compare
Purpose
Approach
Samples
Remarks
Check List