Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BInvokableType record fields of effective types not inheriting readonly flag #42582

Conversation

Thushara-Piyasekara
Copy link
Contributor

@Thushara-Piyasekara Thushara-Piyasekara commented Apr 18, 2024

Purpose

Fixes #42439

Approach

When generating the effective types, the original type is cloned. But during the cloning process the original flags of BInvokableType fields of BRecordType were not inherited properly. With this PR we fixed this inheritance issue.

Samples

Remarks

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@Thushara-Piyasekara Thushara-Piyasekara marked this pull request as ready for review April 18, 2024 07:41
@Thushara-Piyasekara Thushara-Piyasekara changed the title Fix BInvokableType fields of effective types not inheriting readonly flag Fix BInvokableType record fields of effective types not inheriting readonly flag Apr 19, 2024
Copy link

github-actions bot commented May 4, 2024

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label May 4, 2024
Copy link

github-actions bot commented May 7, 2024

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this May 7, 2024
@xlight05 xlight05 reopened this May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.06%. Comparing base (69dab2f) to head (6f80e98).
Report is 948 commits behind head on openhealth-readonly-fix.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             openhealth-readonly-fix   #42582      +/-   ##
=============================================================
+ Coverage                      77.29%   78.06%   +0.76%     
- Complexity                     51352    58632    +7280     
=============================================================
  Files                           2932     3492     +560     
  Lines                         204510   232171   +27661     
  Branches                       26691    32749    +6058     
=============================================================
+ Hits                          158086   181239   +23153     
- Misses                         37834    41436    +3602     
- Partials                        8590     9496     +906     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jun 23, 2024
@github-actions github-actions bot removed the Stale label Jun 26, 2024
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added Stale and removed Stale labels Jul 12, 2024
Copy link

github-actions bot commented Aug 1, 2024

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added Stale and removed Stale labels Aug 1, 2024
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Aug 19, 2024
Copy link

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this Aug 24, 2024
@ayeshLK ayeshLK removed the Stale label Sep 6, 2024
@gimantha gimantha marked this pull request as draft September 10, 2024 03:34
@gimantha gimantha marked this pull request as ready for review October 8, 2024 11:30
@gimantha gimantha changed the base branch from master to openhealth-readonly-fix October 8, 2024 11:31
@gimantha gimantha merged commit 0006b9d into ballerina-platform:openhealth-readonly-fix Oct 8, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect compiler incompatible types error when a type is of the expected type
7 participants