Fix BFields of generated immutable BRecords not being marked as SymbolFlags.READONLY
#42521
Conversation
Thushara-Piyasekara
force-pushed
the
fix-error-code-inconsistency
branch
2 times, most recently
from
98020f7
to
a96071c
Compare
Thushara-Piyasekara
force-pushed
the
fix-error-code-inconsistency
branch
from
a96071c
to
26702f7
Compare
Thushara-Piyasekara
force-pushed
the
fix-error-code-inconsistency
branch
from
26702f7
to
3e017ec
Compare
...est/java/org/ballerinalang/test/types/readonly/TupleVsArrayReadonlyErrorConsistencyTest.java
Outdated
Show resolved
Hide resolved
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
...est/java/org/ballerinalang/test/types/readonly/TupleVsArrayReadonlyErrorConsistencyTest.java
Outdated
Show resolved
Hide resolved
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
Closed PR due to inactivity for more than 18 days. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42521 +/- ##
============================================
+ Coverage 77.35% 77.52% +0.17%
- Complexity 58588 58718 +130
============================================
Files 3460 3447 -13
Lines 220086 219720 -366
Branches 28909 28938 +29
============================================
+ Hits 170237 170329 +92
+ Misses 40432 39970 -462
- Partials 9417 9421 +4 ☔ View full report in Codecov by Sentry. |
...erina-unit-test/src/test/java/org/ballerinalang/test/javainterop/basic/StaticMethodTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/ballerinalang/test/types/readonly/TupleVsArrayReadonlyErrorConsistencyTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/ballerinalang/test/types/readonly/TupleVsArrayReadonlyErrorConsistencyTest.java
Outdated
Show resolved
Hide resolved
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
…ina-lang into fix-error-code-inconsistency
...t/java/org/ballerinalang/test/expressions/mappingconstructor/MappingConstructorExprTest.java
Show resolved
Hide resolved
...t/java/org/ballerinalang/test/expressions/mappingconstructor/MappingConstructorExprTest.java
Outdated
Show resolved
Hide resolved
| expectedExceptionsMessageRegExp = "error: \\{ballerina/lang.map}InherentTypeViolation \\{\"message\":" + | ||
| "\"cannot update 'readonly' field 'name' in record of type 'Details & readonly'\".*") | ||
| public void testCreateDetails() { | ||
| BRunUtil.invoke(result, "testCreateDetails"); |
There was a problem hiding this comment.
If the entire record is immutable, the former error is better?
There was a problem hiding this comment.
Imo, the new message is more meaningful.
And also the new error message is the one we normally get, when we updating a immuatable value
...est/resources/test-src/types/readonly/test_tuple_vs_array_readonly_violation_consistency.bal
Outdated
Show resolved
Hide resolved
SasinduDilshara
requested review from
gimantha,
KavinduZoysa and
azinneera
as code owners
Purpose
Fixes #42520
Approach
After a discussion with @heshanpadmasiri, it was apparent the
InherentTypeViolationerror forBFieldsof readonlyBRecordswere not getting triggered. This was due to the mutableBRecordgeneration not inheriting the readonly flag to the generatedBFields.After refactoring the logic to make the
BFieldsalso inherit the readonly flag, both cases mentioned in #42520 triggered the same error.Samples
Remarks
Check List