Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port nBallerina cell type to jBallerina #42285

Conversation

lochana-chathura
Copy link
Member

@lochana-chathura lochana-chathura commented Mar 6, 2024

Purpose

$subject. Here we are porting cell.bal from nBallerina.

This will port the changes introduced in ballerina-platform/nballerina#1052

Fixes #42269

Approach

n/a

Samples

n/a

Remarks

n/a

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@lochana-chathura lochana-chathura added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Mar 6, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 76.50%. Comparing base (c3e746c) to head (d2e74de).
Report is 1 commits behind head on nutcracker.

Files Patch % Lines
.../java/io/ballerina/types/typeops/BddCommonOps.java 27.77% 12 Missing and 1 partial ⚠️
.../main/java/io/ballerina/types/typeops/CellOps.java 83.07% 8 Missing and 3 partials ⚠️
.../src/main/java/io/ballerina/types/CellSemType.java 75.00% 0 Missing and 1 partial ⚠️
...types/src/main/java/io/ballerina/types/Common.java 80.00% 1 Missing ⚠️
...emtypes/src/main/java/io/ballerina/types/Core.java 0.00% 0 Missing and 1 partial ⚠️
...va/io/ballerina/types/subtypedata/CellSubtype.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             nutcracker   #42285      +/-   ##
================================================
+ Coverage         76.25%   76.50%   +0.25%     
- Complexity        53417    53679     +262     
================================================
  Files              2933     2937       +4     
  Lines            202594   202699     +105     
  Branches          26511    26529      +18     
================================================
+ Hits             154486   155073     +587     
+ Misses            39533    38986     -547     
- Partials           8575     8640      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lochana-chathura
Copy link
Member Author

Added the same test cases as per the original nBallerina PR. Will revisit missing coverage lines once the porting is completed.

Copy link
Member

@heshanpadmasiri heshanpadmasiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lochana-chathura lochana-chathura added the Area/SemtypePort Issues related to porting of semantic subtyping label Mar 12, 2024
@lochana-chathura lochana-chathura merged commit 82165dd into ballerina-platform:nutcracker Mar 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/SemtypePort Issues related to porting of semantic subtyping Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants