-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port nBallerina cell type to jBallerina #42285
Port nBallerina cell type to jBallerina #42285
Conversation
7f0d1f6
to
f519976
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nutcracker #42285 +/- ##
================================================
+ Coverage 76.25% 76.50% +0.25%
- Complexity 53417 53679 +262
================================================
Files 2933 2937 +4
Lines 202594 202699 +105
Branches 26511 26529 +18
================================================
+ Hits 154486 155073 +587
+ Misses 39533 38986 -547
- Partials 8575 8640 +65 ☔ View full report in Codecov by Sentry. |
Added the same test cases as per the original nBallerina PR. Will revisit missing coverage lines once the porting is completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
82165dd
into
ballerina-platform:nutcracker
Purpose
$subject. Here we are porting
cell.bal
from nBallerina.This will port the changes introduced in ballerina-platform/nballerina#1052
Fixes #42269
Approach
n/a
Samples
n/a
Remarks
n/a
Check List