Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XML navigation result when namespace is declared in a statement after the the expression #42217

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

poorna2152
Copy link
Contributor

@poorna2152 poorna2152 commented Feb 22, 2024

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #42185
Fixes #42200

Approach

Save the namespace symbol of the BLangXMLElementFilter expression in the TypeChecker phase using the set of visible namespaces and use that information in the Desugar phase to expand the filter name. Accessing the set of namespaces in the Desugar phase provides namespaces that are defined after the filter expression declaration.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@poorna2152 poorna2152 added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.50%. Comparing base (37b79d9) to head (ace31bb).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #42217   +/-   ##
=========================================
  Coverage     76.50%   76.50%           
- Complexity    53173    53184   +11     
=========================================
  Files          2892     2892           
  Lines        200992   201000    +8     
  Branches      26186    26189    +3     
=========================================
+ Hits         153769   153783   +14     
+ Misses        38763    38759    -4     
+ Partials       8460     8458    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KavinduZoysa KavinduZoysa merged commit 71fdc93 into ballerina-platform:master Mar 25, 2024
18 checks passed
@MaryamZi MaryamZi added this to the 2201.9.0 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
4 participants