-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix XML navigation result when namespace is declared in a statement after the the expression #42217
Merged
KavinduZoysa
merged 5 commits into
ballerina-platform:master
from
poorna2152:xml_nav_stmt_2
Mar 25, 2024
Merged
Fix XML navigation result when namespace is declared in a statement after the the expression #42217
KavinduZoysa
merged 5 commits into
ballerina-platform:master
from
poorna2152:xml_nav_stmt_2
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorna2152
requested review from
sameerajayasoma and
hasithaa
as code owners
February 22, 2024 09:58
poorna2152
added
the
Team/CompilerFE
All issues related to Language implementation and Compiler, this exclude run times.
label
Feb 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42217 +/- ##
=========================================
Coverage 76.50% 76.50%
- Complexity 53173 53184 +11
=========================================
Files 2892 2892
Lines 200992 201000 +8
Branches 26186 26189 +3
=========================================
+ Hits 153769 153783 +14
+ Misses 38763 38759 -4
+ Partials 8460 8458 -2 ☔ View full report in Codecov by Sentry. |
tests/jballerina-unit-test/src/test/resources/test-src/types/xml/xml-navigation-access.bal
Outdated
Show resolved
Hide resolved
MaryamZi
reviewed
Mar 19, 2024
tests/jballerina-unit-test/src/test/resources/test-src/types/xml/xml-navigation-access.bal
Show resolved
Hide resolved
tests/jballerina-unit-test/src/test/resources/test-src/types/xml/xml-navigation-access.bal
Outdated
Show resolved
Hide resolved
tests/jballerina-unit-test/src/test/resources/test-src/types/xml/xml-navigation-access.bal
Outdated
Show resolved
Hide resolved
...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
Outdated
Show resolved
Hide resolved
...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
Outdated
Show resolved
Hide resolved
tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/types/xml/XMLAccessTest.java
Outdated
Show resolved
Hide resolved
poorna2152
force-pushed
the
xml_nav_stmt_2
branch
from
March 21, 2024 17:19
db4eb43
to
bc43aec
Compare
MaryamZi
reviewed
Mar 22, 2024
tests/jballerina-unit-test/src/test/resources/test-src/types/xml/xml-navigation-access.bal
Outdated
Show resolved
Hide resolved
poorna2152
force-pushed
the
xml_nav_stmt_2
branch
from
March 22, 2024 06:30
bc43aec
to
ace31bb
Compare
...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
Show resolved
Hide resolved
MaryamZi
approved these changes
Mar 25, 2024
KavinduZoysa
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team/CompilerFE
All issues related to Language implementation and Compiler, this exclude run times.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #42185
Fixes #42200
Approach
Save the namespace symbol of the
BLangXMLElementFilter
expression in the TypeChecker phase using the set of visible namespaces and use that information in the Desugar phase to expand the filter name. Accessing the set of namespaces in the Desugar phase provides namespaces that are defined after the filter expression declaration.Samples
Remarks
Check List