Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark platform as any for testOnly platform libs #41033

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

ShammiL
Copy link
Contributor

@ShammiL ShammiL commented Jul 17, 2023

Purpose

$Subject

Fixes #40852

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 89.87% and project coverage change: -0.02% ⚠️

Comparison is base (e7f7f2c) 76.45% compared to head (1748cb7) 76.43%.
Report is 57 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #41033      +/-   ##
============================================
- Coverage     76.45%   76.43%   -0.02%     
- Complexity    52154    52214      +60     
============================================
  Files          2856     2857       +1     
  Lines        196001   196184     +183     
  Branches      25416    25451      +35     
============================================
+ Hits         149843   149948     +105     
- Misses        37857    37920      +63     
- Partials       8301     8316      +15     
Files Changed Coverage Δ
.../langserver/common/constants/CommandConstants.java 90.00% <ø> (ø)
...va/io/ballerina/projects/JBallerinaBalaWriter.java 84.68% <36.36%> (-4.64%) ⬇️
...rs/imports/AddModuleToBallerinaTomlCodeAction.java 80.00% <80.00%> (ø)
.../compiler/semantics/analyzer/DataflowAnalyzer.java 89.96% <97.18%> (+0.45%) ⬆️
...ava/io/ballerina/runtime/internal/TypeChecker.java 80.98% <100.00%> (+0.04%) ⬆️
...g/wso2/ballerinalang/compiler/desugar/Desugar.java 89.33% <100.00%> (-0.97%) ⬇️
.../compiler/semantics/analyzer/QueryTypeChecker.java 89.25% <100.00%> (+0.04%) ⬆️
.../compiler/semantics/analyzer/SemanticAnalyzer.java 90.61% <100.00%> (-0.01%) ⬇️
...alang/compiler/semantics/analyzer/TypeChecker.java 91.68% <100.00%> (-0.08%) ⬇️
...llerinalang/compiler/semantics/analyzer/Types.java 81.76% <100.00%> (-0.01%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Aug 2, 2023
@ShammiL ShammiL removed the Stale label Aug 3, 2023
@azinneera azinneera merged commit cebd881 into ballerina-platform:master Aug 15, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Derive platform as any when testOnly platform dependencies are provided
2 participants