Update isolated analysis in the init method

[MaryamZi]

Purpose

$title.

Fixes #40736

Check List

• Read the Contributing Guide
• Updated Change Log
• Checked Tooling Support (#)
• Added necessary tests
  • Unit Tests
  • Spec Conformance Tests
  • Integration Tests
  • Ballerina By Example Tests
• Increased Test Coverage
• Added necessary documentation
  • API documentation
  • Module documentation in Module.md files
  • Ballerina By Examples

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +76.43% 🎉

Comparison is base (a9e9d76) 0.00% compared to head (18ec04a) 76.43%.

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #40757       +/-   ##
=============================================
+ Coverage      0.00%   76.43%   +76.43%     
- Complexity        0    52435    +52435     
=============================================
  Files             9     2863     +2854     
  Lines            35   197402   +197367     
  Branches          0    25596    +25596     
=============================================
+ Hits              0   150886   +150886     
- Misses           35    38171    +38136     
- Partials          0     8345     +8345     

Files Changed	Coverage Δ
...compiler/semantics/analyzer/IsolationAnalyzer.java	85.62% <100.00%> (ø)

... and 2861 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

[chiranSachintha]

Consider the following example. Is it correct to access arr without a lock inside the lambda function? The following program compile without any errors.

isolated class IsolatedClass {
    private int[][] arr;

    function init(int[] node) {
        self.arr = [];
        function v = function () {
            self.arr.push(node);
        };
    }
}

[MaryamZi]

Consider the following example. Is it correct to access arr without a lock inside the lambda function? The following program compile without any errors.

isolated class IsolatedClass {
    private int[][] arr;

    function init(int[] node) {
        self.arr = [];
        function v = function () {
            self.arr.push(node);
        };
    }
}

Seems like there is an issue here, but is also the case in non-init methods. Can you please create an issue for this?

[dulajdilshan]

We can remove the new line in L2634?. (Ignorable)

[dulajdilshan]

LGTM!. Only minor ignorable comment.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint