Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master] Improve diagnostic message when there is a union type in the select clause #40642

Conversation

LakshanWeerasinghe
Copy link
Contributor

Purpose

$subject

Fixes #40013

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@LakshanWeerasinghe LakshanWeerasinghe added Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Lang/Expressions/Query labels Jun 8, 2023
@LakshanWeerasinghe LakshanWeerasinghe added this to the 2201.7.0 milestone Jun 15, 2023
@@ -318,3 +318,56 @@ function testQueryActionOrExprWithActionsInJoinClause() {
}

int[][] globalQuery = from var i in 1...3 select start f1();

type T1 record {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add few ambiguity tests as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added only single test since few of other tests are already found here

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 58.72% and project coverage change: +0.01 🎉

Comparison is base (3542aa0) 76.43% compared to head (2aff8cd) 76.45%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40642      +/-   ##
============================================
+ Coverage     76.43%   76.45%   +0.01%     
- Complexity    55210    55214       +4     
============================================
  Files          3380     3377       -3     
  Lines        208012   207977      -35     
  Branches      26918    26921       +3     
============================================
+ Hits         158995   158999       +4     
+ Misses        40272    40231      -41     
- Partials       8745     8747       +2     
Impacted Files Coverage Δ
...erina/runtime/internal/BallerinaXmlSerializer.java 80.28% <0.00%> (ø)
.../ballerina/runtime/internal/TableOmDataSource.java 0.00% <0.00%> (ø)
...java/io/ballerina/runtime/internal/TableUtils.java 72.09% <0.00%> (ø)
...a/io/ballerina/runtime/internal/TypeConverter.java 67.32% <0.00%> (ø)
...java/io/ballerina/runtime/internal/XmlFactory.java 57.89% <0.00%> (ø)
...ternal/configurable/providers/cli/CliProvider.java 92.46% <ø> (ø)
...me/internal/configurable/providers/toml/Utils.java 85.45% <ø> (ø)
...ime/internal/diagnostics/RuntimeDiagnosticLog.java 100.00% <ø> (ø)
...allerina/runtime/internal/errors/ErrorReasons.java 100.00% <ø> (ø)
...llerina/runtime/internal/scheduling/Scheduler.java 77.92% <0.00%> (ø)
... and 115 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LakshanWeerasinghe LakshanWeerasinghe removed this from the 2201.7.0 milestone Jun 16, 2023
@github-actions
Copy link

github-actions bot commented Jul 1, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jul 1, 2023
@pcnfernando pcnfernando removed the Stale label Jul 2, 2023
@LakshanWeerasinghe
Copy link
Contributor Author

Closing this PR since #40835 will address the things in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lang/Expressions/Query Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Compilation fails when using ternary expression within select clauses
3 participants