-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Master] Support list-constructor-expr in module constant declaration #40621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #40621 +/- ##
============================================
+ Coverage 76.45% 76.62% +0.16%
- Complexity 55300 55401 +101
============================================
Files 3388 3388
Lines 208326 208354 +28
Branches 26970 26976 +6
============================================
+ Hits 159283 159656 +373
+ Misses 40273 39898 -375
- Partials 8770 8800 +30
☔ View full report in Codecov by Sentry. |
prakanth97
requested review from
hevayo,
mohanvive,
IMS94,
sameerajayasoma and
hasithaa
as code owners
June 7, 2023 17:49
ushirask
reviewed
Jun 8, 2023
...ng/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/ConstantTypeChecker.java
Outdated
Show resolved
Hide resolved
ushirask
reviewed
Jun 8, 2023
...ng/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/ConstantTypeChecker.java
Outdated
Show resolved
Hide resolved
ushirask
reviewed
Jun 8, 2023
...s/jballerina-unit-test/src/test/resources/test-src/types/constant/list_constant_negative.bal
Show resolved
Hide resolved
13 tasks
prakanth97
force-pushed
the
issue_40572
branch
2 times, most recently
from
June 22, 2023 04:02
d723e10
to
69d696d
Compare
ushirask
reviewed
Jun 22, 2023
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
Outdated
Show resolved
Hide resolved
For this, we got runtime error as below,
Seems value passed as |
prakanth97
added
the
Team/CompilerFE
All issues related to Language implementation and Compiler, this exclude run times.
label
Jun 28, 2023
hasithaa
reviewed
Jul 5, 2023
...t-test/src/test/resources/test-src/types/constant/list_constructor_expr_as_constant_expr.bal
Show resolved
Hide resolved
Fixed in d97530c |
prakanth97
changed the title
Support list-constructor-expr in module constant declaration
[Master] Support list-constructor-expr in module constant declaration
Jul 5, 2023
hasithaa
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team/CompilerFE
All issues related to Language implementation and Compiler, this exclude run times.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #40572
Samples
List constants are not supported previously. In this we are supporting it.
Remarks
#39589
#40535
Check List