Implement logging warnings for deprecated param usages in funcion call and fix inconsistent behaviour in warnings in deprecated record fields

compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/CodeAnalyzer.java

@@ -31,6 +31,7 @@
 import org.ballerinalang.model.tree.expressions.XMLNavigationAccess;
 import org.ballerinalang.model.tree.statements.StatementNode;
 import org.ballerinalang.model.tree.statements.VariableDefinitionNode;
+import org.ballerinalang.model.types.TypeKind;
 import org.ballerinalang.util.diagnostic.DiagnosticErrorCode;
 import org.ballerinalang.util.diagnostic.DiagnosticHintCode;
 import org.ballerinalang.util.diagnostic.DiagnosticWarningCode;
@@ -2233,21 +2234,59 @@
     @Override
     public void visit(BLangRecordLiteral recordLiteral, AnalyzerData data) {
         List<RecordLiteralNode.RecordField> fields = recordLiteral.fields;
+        BType recLiteralType = recordLiteral.getBType();
 
         for (RecordLiteralNode.RecordField field : fields) {
             if (field.isKeyValueField()) {
                 analyzeExpr(((BLangRecordKeyValueField) field).valueExpr, data);
+
+                BVarSymbol fieldSymbol = ((BLangRecordKeyValueField) field).key.fieldSymbol;
+                if (fieldSymbol != null) {
+                    reportIfDeprecatedUsage(fieldSymbol, fieldSymbol.toString(),
+                            recordLiteral, ((BLangRecordKeyValueField) field).pos);
+                }
             } else if (field.getKind() == NodeKind.SIMPLE_VARIABLE_REF) {
-                analyzeExpr((BLangRecordLiteral.BLangRecordVarNameField) field, data);
+                BLangRecordLiteral.BLangRecordVarNameField recField
+                        = (BLangRecordLiteral.BLangRecordVarNameField) field;
+                analyzeExpr(recField, data);
+
+                if (recLiteralType.tsymbol != null && recLiteralType.tsymbol.type != null
+                        && recLiteralType.tsymbol.type.getKind() == TypeKind.RECORD) {
+
+                    BRecordType recordType = (BRecordType) recLiteralType.tsymbol.type;
+                    BField matchingField = recordType.getFields().get(recField.symbol.getName().getValue());
+
+                    if (matchingField != null && matchingField.symbol != null) {
+                        reportIfDeprecatedUsage(matchingField.symbol, matchingField.name.getValue(),
+                                recordLiteral, ((BLangRecordLiteral.BLangRecordVarNameField) field).pos);
+                    }
+                }
             } else {
-                analyzeExpr(((BLangRecordLiteral.BLangRecordSpreadOperatorField) field).expr, data);
+                BLangRecordLiteral.BLangRecordSpreadOperatorField spreadField
+                        = (BLangRecordLiteral.BLangRecordSpreadOperatorField) field;
+                analyzeExpr(spreadField.expr, data);
+
+                BType spreadFieldType = Types.getReferredType(spreadField.expr.getBType());
+                BType contextType = Types.getReferredType(recLiteralType);
+
+                if (spreadFieldType != null && spreadFieldType.getKind() == TypeKind.RECORD
+                        && contextType.getKind() == TypeKind.RECORD) {
+                    for (BField fieldEntry: ((BRecordType) spreadFieldType).getFields().values()) {
+                        BRecordType recordType = (BRecordType) contextType;
+                        BField matchingField = recordType.getFields().get(fieldEntry.getName().getValue());
+
+                        if (matchingField != null && matchingField.symbol != null) {
+                            reportIfDeprecatedUsage(matchingField.symbol, matchingField.name.getValue(),
+                                    recordLiteral, spreadField.expr.pos);
+                        }
+                    }
+                }
             }
         }
 
         Set<Object> names = new HashSet<>();
         Set<Object> neverTypedKeys = new HashSet<>();
-        BType literalBType = recordLiteral.getBType();
-        BType type = Types.getReferredType(literalBType);
+        BType type = Types.getReferredType(recLiteralType);
         boolean isRecord = type.tag == TypeTags.RECORD;
         boolean isOpenRecord = isRecord && !((BRecordType) type).sealed;
 
@@ -2465,10 +2504,8 @@
         BLangExpression expr = fieldAccessExpr.expr;
         analyzeExpr(expr, data);
         BSymbol symbol = fieldAccessExpr.symbol;
-        if (symbol != null && Symbols.isFlagOn(fieldAccessExpr.symbol.flags, Flags.DEPRECATED)) {
-            String deprecatedConstruct = generateDeprecatedConstructString(expr, fieldAccessExpr.field.toString(),
-                    symbol);
-            dlog.warning(fieldAccessExpr.pos, DiagnosticWarningCode.USAGE_OF_DEPRECATED_CONSTRUCT, deprecatedConstruct);
+        if (symbol != null) {
+            reportIfDeprecatedUsage(symbol, fieldAccessExpr.field.toString(), expr, fieldAccessExpr.pos);
         }
     }
 
@@ -2496,6 +2533,7 @@
                 logDeprecatedWarningForInvocation(invocationExpr);
             }
         }
+        analyzeInvocationParams(invocationExpr, data);
     }
 
     @Override
@@ -3875,6 +3913,57 @@
                 && data.withinTransactionScope;
     }
 
+    private void analyzeInvocationParams(BLangInvocation iExpr, AnalyzerData data) {
+        if (iExpr.symbol == null) {
+            return;
+        }
+
+        BType invocableType = Types.getReferredType(iExpr.symbol.type);
+        if (invocableType.tag != TypeTags.INVOKABLE) {
+            return;
+        }
+
+        BInvokableSymbol invokableSymbol = ((BInvokableSymbol) iExpr.symbol);
+        int parameterCountForPositionalArgs = ((BInvokableType) invocableType).getParameterTypes().size();
+
+        int i = 0;
+        boolean foundNamedArg = false;
+        for (BLangExpression expr : iExpr.argExprs) {
+            switch (expr.getKind()) {
+                case NAMED_ARGS_EXPR:
+                    foundNamedArg = true;
+                    BLangNamedArgsExpression namedArgsExpression = (BLangNamedArgsExpression) expr;
+                    if (namedArgsExpression.varSymbol != null) {
+                        reportIfDeprecatedUsage(namedArgsExpression.varSymbol, namedArgsExpression.varSymbol.toString(),
+                                expr, expr.pos);
+                    }
+                    i++;
+                    break;
+                case REST_ARGS_EXPR:
+                    if (foundNamedArg) {
+                        continue;
+                    }
+                    analyzeExpr(expr, data);
+                    break;
+                default:    // positional args
+                    if (foundNamedArg) {
+                        continue;
+                    }
+                    if (i < parameterCountForPositionalArgs) {
+                        BVarSymbol paramSymbol = invokableSymbol.params.get(i);
+                        if (paramSymbol != null && Symbols.isFlagOn(paramSymbol.flags, Flags.DEPRECATED)) {
+                            logDeprecatedWaring(paramSymbol.toString(), paramSymbol, expr.pos);
+                        }
+                        if (Symbols.isFlagOn(invokableSymbol.params.get(i).flags, Flags.INCLUDED)) {
+                            analyzeExpr(expr, data);
+                        }
+                    }
+                    i++;
+
+            }
+        }
+    }
+
     private void validateModuleInitFunction(BLangFunction funcNode) {
         if (funcNode.attachedFunction || !Names.USER_DEFINED_INIT_SUFFIX.value.equals(funcNode.name.value)) {
             return;
@@ -3925,6 +4014,16 @@
         return errorType;
     }
 
+    private void reportIfDeprecatedUsage(BSymbol constructSymbol,
+                                         String constructName,
+                                         BLangExpression expr,
+                                         Location usagePos) {
+        if (Symbols.isFlagOn(constructSymbol.flags, Flags.DEPRECATED)) {
+            dlog.warning(usagePos, DiagnosticWarningCode.USAGE_OF_DEPRECATED_CONSTRUCT,
+                    generateDeprecatedConstructString(expr, constructName, constructSymbol));
+        }
+    }
+
     /**
      * This class contains the state machines for a set of workers.
      */

tests/jballerina-unit-test/src/test/java/org/ballerinalang/test/annotations/DeprecationAnnotationTest.java

@@ -67,7 +67,13 @@ public void testDeprecationAnnotation() {
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Object3.fieldOne' is deprecated", 194, 9);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Object3.t' is deprecated", 195, 9);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'add1' is deprecated", 200, 13);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'x' is deprecated", 200, 18);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'y' is deprecated", 200, 21);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'z' is deprecated", 200, 24);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'add2' is deprecated", 201, 13);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'x' is deprecated", 201, 18);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'y' is deprecated", 201, 21);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'z' is deprecated", 201, 24);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Object1' is deprecated", 202, 5);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'z' is deprecated", 213, 13);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Foo' is deprecated", 216, 38);
@@ -86,20 +92,45 @@ public void testDeprecationAnnotation() {
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Person.name' is deprecated", 287, 16);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Person.getName' is deprecated", 288, 16);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'myFunction' is deprecated", 298, 5);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Employee.name' is deprecated", 316, 26);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Employee.job' is deprecated", 316, 49);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Job.experience' is deprecated", 316, 68);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Employee.name' is deprecated", 317, 9);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Employee.job' is deprecated", 319, 9);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Employee.job' is deprecated", 320, 9);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Employee.job' is deprecated", 321, 9);
-        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Job.experiance' is deprecated", 321, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Job.experience' is deprecated", 321, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Employee2.name' is deprecated", 343, 28);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Employee2.job' is deprecated", 343, 51);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Job.experience' is deprecated", 343, 70);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Employee2.name' is deprecated", 344, 9);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Employee2.job' is deprecated", 346, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'name' is deprecated", 354, 17);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'name' is deprecated", 357, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'name' is deprecated", 370, 17);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'name' is deprecated", 373, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Employee5.address' is deprecated",
+                393, 28);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Employee5.address' is deprecated",
                 394, 9);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Employee5.address' is deprecated",
                 395, 9);
         BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'line02' is deprecated", 395, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Job.experience' is deprecated", 414, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Job.experience' is deprecated", 420, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Job.experience' is deprecated", 426, 12);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Company.name' is deprecated", 433, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Company.city' is deprecated", 434, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Company.country' is deprecated", 435, 12);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'x2' is deprecated", 446, 15);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'x2' is deprecated", 447, 15);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'x2' is deprecated", 448, 20);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Company.city' is deprecated", 451, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Company.country' is deprecated", 452, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'Company.name' is deprecated", 453, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'city' is deprecated", 458, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'country' is deprecated", 459, 9);
+        BAssertUtil.validateWarning(compileResult, i++, "usage of construct 'name' is deprecated", 460, 9);
         Assert.assertEquals(compileResult.getWarnCount(), i);
     }
 

tests/jballerina-unit-test/src/test/resources/test-src/annotations/deprecation_annotation.bal

@@ -309,16 +309,16 @@ type Employee record {|
 type Job record {|
     string title;
     @deprecated
-    int experiance;
+    int experience;
 |};
 
 public function testDeprecatedRecordFields() {
-    Employee employee = {name: "John", id: 112, job: {title: "SE", experiance: 2}};
+    Employee employee = {name: "John", id: 112, job: {title: "SE", experience: 2}};
     _ = employee.name; // warning
     _ = employee.id;
     _ = employee.job; // warning
     _ = employee.job.title; // warning
-    _ = employee.job.experiance; // warning
+    _ = employee.job.experience; // warning
 }
 
 # Employee2 record
@@ -340,7 +340,7 @@ type Employee2 record {|
 |};
 
 public function testDeprecatedRecordFieldsWithDocumentation() {
-    Employee2 employee2 = {name: "John", id: 112, job: {title: "SE", experiance: 2}};
+    Employee2 employee2 = {name: "John", id: 112, job: {title: "SE", experience: 2}};
     _ = employee2.name; // warning
     _ = employee2.id;
     _ = employee2.job; // warning
@@ -390,7 +390,73 @@ type Employee5 record {
 };
 
 public function testDeprecatedAnonStructAsStructField() {
-    Employee5 employee5 = {address: {}};
+    Employee5 employee5 = {address: {}};    // warning
     _ = employee5.address;  // warning
     _ = employee5.address.line02;   // warning
 }
+
+type Company record {
+    int companyId;
+
+    @deprecated
+    string name;
+
+    @deprecated
+    string city;
+
+    @deprecated
+    string country;
+};
+
+public function testDeprecatedAnonRecordFieldInInitialization() {
+     Job _ = {
+        title: "SE",
+        experience: 1  // warning
+    };
+
+    int experience = 2;
+    Job _ = {
+        title: "SE",
+        experience  // warning
+    };
+
+    var details = {experience: 2};
+    Job _ = {
+        title: "SE",
+        ...details  // warning
+    };
+
+    string city = "Berlin";
+    var companyDetails = {country: "Germany"};
+    Company _ = {
+        companyId: 1,
+        name: "Foo",    // warning
+        city: city,     // warning
+        ...companyDetails   // warning
+    };
+}
+
+function fooFn(int x1, @deprecated int x2){
+}
+
+function barFn(string s, *Company company) {
+}
+
+public function testDeprecatedParamUsages() {
+    fooFn(10, 11);
+    fooFn(12, x2 = 13);
+    fooFn(x1 = 14, x2 = 15);
+    barFn("bar", {
+        companyId: 1,
+        city: "Berlin", // Warning
+        country: "Germany", // Warning
+        name: "Bar" // Warning
+    });
+    barFn(
+        "bar",
+        companyId = 1,
+        city = "Berlin", // Warning
+        country = "Germany", // Warning
+        name = "Bar" // Warning
+    );
+}