Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.2.x] Close unclosed output streams created for JsonGenerator #40330

Merged
merged 2 commits into from
May 9, 2023
Merged

[1.2.x] Close unclosed output streams created for JsonGenerator #40330

merged 2 commits into from
May 9, 2023

Conversation

gabilang
Copy link
Contributor

@gabilang gabilang commented Apr 28, 2023 •
edited
Loading

Purpose

$title

Fixes #40309

Approach

Samples

Remarks

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@gabilang gabilang added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Apr 28, 2023
@gabilang gabilang changed the title Close unclosed output streams created for JsonGenerator [1.2.x] Close unclosed output streams created for JsonGenerator Apr 28, 2023
Nadeeshan96
Nadeeshan96 approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@Nadeeshan96 Nadeeshan96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

warunalakshitha
warunalakshitha approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha merged commit 5bf1494 into ballerina-platform:ballerina-1.2.x May 9, 2023
@gabilang gabilang mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warunalakshitha warunalakshitha warunalakshitha approved these changes

@Nadeeshan96 Nadeeshan96 Nadeeshan96 approved these changes

@HindujaB HindujaB Awaiting requested review from HindujaB

Assignees
No one assigned
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabilang @warunalakshitha @Nadeeshan96