-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several CCE issues in query expressions that has string and xml types as the expected type. #40041
Merged
pcnfernando
merged 7 commits into
ballerina-platform:master
from
SasinduDilshara:issue_39641_changes
Jul 10, 2023
Merged
Fix several CCE issues in query expressions that has string and xml types as the expected type. #40041
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
44b24cf
Fix CCE issues in xml and string query expressions
SasinduDilshara 35ec756
Update select type resolver func with if-else stmt
SasinduDilshara 33d8472
Remove unnecessary newlines in string query tests
SasinduDilshara ae6e8eb
Update license header in string query exp test
SasinduDilshara 8c67143
Update license heaser in string query neg tests
SasinduDilshara e77b20a
refactor xml query expression bal files
SasinduDilshara 4bc3a90
Merge branch 'master' of https://github.com/ballerina-platform/baller…
SasinduDilshara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
...allerina-unit-test/src/test/resources/test-src/query/string-query-expression-negative.bal
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
// Copyright (c) 2023 WSO2 LLC. (http://www.wso2.org) All Rights Reserved. | ||
// | ||
// WSO2 LLC. licenses this file to you under the Apache License, | ||
// Version 2.0 (the "License"); you may not use this file except | ||
// in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, | ||
// software distributed under the License is distributed on an | ||
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
// KIND, either express or implied. See the License for the | ||
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
type Book record {| | ||
string title; | ||
string author; | ||
|}; | ||
|
||
class BookGenerator { | ||
int i = 0; | ||
|
||
public isolated function next() returns record {|Book value;|}|error? { | ||
self.i += 1; | ||
if (self.i < 0) { | ||
return error("Error"); | ||
} else if (self.i >= 3) { | ||
return (); | ||
} | ||
return { | ||
value: { | ||
title: "Title " + self.i.toString(), author: "Author " + self.i.toString() | ||
} | ||
}; | ||
} | ||
} | ||
|
||
function testSimpleQueryExprForStringNegative() returns error? { | ||
string:Char chr = "a"; | ||
BookGenerator bookGenerator = new (); | ||
stream<Book, error?> bookStream = new (bookGenerator); | ||
|
||
string:Char[]|string _ = check from Book _ in bookStream | ||
select chr; | ||
string:Char[]|int|string _ = check from Book _ in bookStream | ||
select chr; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add a negative test for ambiguous types also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add it to
xml|xml[]
case tooThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added tests for ambiguous situations in both
string
,xml
.But those tests will uncomment after fixing #40012