Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Consider on-fail as an execution branch when possible failure is reached" #39951

Merged

Conversation

pcnfernando
Copy link
Member

@pcnfernando pcnfernando commented Mar 22, 2023

Purpose

Reverts #38828

Fixes #

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

Relates to #38530

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.50 🎉

Comparison is base (bbc7dc9) 76.47% compared to head (d81e938) 76.97%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #39951      +/-   ##
============================================
+ Coverage     76.47%   76.97%   +0.50%     
- Complexity    53292    54063     +771     
============================================
  Files          3362     3340      -22     
  Lines        199092   201312    +2220     
  Branches      25521    25845     +324     
============================================
+ Hits         152253   154966    +2713     
+ Misses        38488    37951     -537     
- Partials       8351     8395      +44     
Impacted Files Coverage Δ
.../compiler/semantics/analyzer/DataflowAnalyzer.java 89.32% <100.00%> (+0.27%) ⬆️

... and 526 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pcnfernando pcnfernando marked this pull request as ready for review March 22, 2023 06:55
@gimantha gimantha merged commit 64c88d2 into ballerina-platform:master Mar 22, 2023
@pcnfernando pcnfernando added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Mar 22, 2023
@pcnfernando pcnfernando added this to the 2201.5.0 milestone Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants