Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master] Make async-send an action #38245

Merged
merged 25 commits into from
Aug 15, 2023

Conversation

prakanth97
Copy link
Contributor

@prakanth97 prakanth97 commented Oct 17, 2022

Purpose

Fixes #18639
Fixes #24849
Fixes #40759

Approach

Refactor BLangWorkerSend so that it can work as an expression.

Samples

public function main() {
    worker w1 {
        () a = 5 -> w2;
    }

    worker w2 {
        int a = <- w1;
    }
}

This will not give async send action not yet supported as expression error.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@prakanth97 prakanth97 added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Patch coverage: 94.95% and no project coverage change.

Comparison is base (3f153e0) 76.44% compared to head (e7f7f2c) 76.45%.
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #38245   +/-   ##
=========================================
  Coverage     76.44%   76.45%           
+ Complexity    52155    52154    -1     
=========================================
  Files          2856     2856           
  Lines        196005   196001    -4     
  Branches      25418    25416    -2     
=========================================
+ Hits         149839   149843    +4     
+ Misses        37862    37857    -5     
+ Partials       8304     8301    -3     
Files Changed Coverage Δ
...va/io/ballerina/compiler/api/impl/BaseVisitor.java 22.52% <ø> (ø)
...rinalang/compiler/desugar/ClassClosureDesugar.java 32.84% <0.00%> (ø)
...2/ballerinalang/compiler/desugar/QueryDesugar.java 85.92% <0.00%> (+0.06%) ⬆️
...compiler/semantics/analyzer/IsolationAnalyzer.java 85.50% <ø> (ø)
...piler/semantics/analyzer/ReachabilityAnalyzer.java 90.94% <ø> (-0.04%) ⬇️
.../compiler/semantics/analyzer/SemanticAnalyzer.java 90.62% <ø> (+<0.01%) ⬆️
...ballerinalang/compiler/tree/BLangNodeAnalyzer.java 100.00% <ø> (ø)
...lerinalang/compiler/tree/BLangNodeTransformer.java 0.44% <ø> (ø)
.../ballerinalang/compiler/tree/BLangNodeVisitor.java 0.43% <ø> (ø)
...inalang/compiler/tree/SimpleBLangNodeAnalyzer.java 8.64% <ø> (ø)
... and 22 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Nov 16, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label May 5, 2023
@prakanth97 prakanth97 removed the Stale label May 8, 2023
@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jun 9, 2023
@prakanth97 prakanth97 removed the Stale label Jun 12, 2023
@prakanth97
Copy link
Contributor Author

Shall we add more tests to test the behavior of async send in all places where this is allowed to be used now? Check places where action and action-or-expr are allowed in the spec. ex:type casts, check expr, trap, lvexpr etc

Has this comment been addressed?

Added 00909f2

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jul 5, 2023
@prakanth97 prakanth97 removed the Stale label Jul 6, 2023
@github-actions
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jul 21, 2023
@github-actions
Copy link

Closed PR due to inactivity for more than 18 days.

@github-actions github-actions bot closed this Jul 25, 2023
@prakanth97 prakanth97 removed the Stale label Aug 14, 2023
@prakanth97 prakanth97 reopened this Aug 14, 2023
@hasithaa hasithaa merged commit f262094 into ballerina-platform:master Aug 15, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
No open projects
Status: Addressing Review Suggestions
6 participants