Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Master] Fix compiler crashes when a union is used within multiple wait #37832

Merged
merged 34 commits into from
Aug 15, 2023
Merged

[Master] Fix compiler crashes when a union is used within multiple wait #37832

merged 34 commits into from
Aug 15, 2023

Conversation

SasinduDilshara
Copy link
Contributor

Purpose

Fix compiler crashes when a union is used within multiple wait

Fixes #34821

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@SasinduDilshara SasinduDilshara added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Sep 21, 2022
@SasinduDilshara SasinduDilshara changed the title Fix compiler crashes when a union is used within multiple wait [Master] Fix compiler crashes when a union is used within multiple wait Sep 21, 2022
@SasinduDilshara
Copy link
Contributor Author

Create a spec issue for this.
ballerina-platform/ballerina-spec#1171

@SasinduDilshara SasinduDilshara force-pushed the issue-#34821 branch 2 times, most recently from 1dba8da to 8a7ec77 Compare October 19, 2022 09:52
@codecov
Copy link

codecov bot commented Oct 19, 2022 •
edited
Loading

Codecov Report

Patch coverage: 95.83% and project coverage change: +0.16% 🎉

Comparison is base (2be36e6) 76.45% compared to head (3fca4a0) 76.61%.
Report is 96 commits behind head on master.

❗ Current head 3fca4a0 differs from pull request most recent head 511c87c. Consider uploading reports for the commit 511c87c to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #37832      +/-   ##
============================================
+ Coverage     76.45%   76.61%   +0.16%     
- Complexity    52174    55478    +3304     
============================================
  Files          2857     3393     +536     
  Lines        196066   208710   +12644     
  Branches      25430    27024    +1594     
============================================
+ Hits         149898   159903   +10005     
- Misses        37861    39986    +2125     
- Partials       8307     8821     +514
Files Changed Coverage Δ
...alang/compiler/semantics/analyzer/TypeChecker.java 91.74% <93.33%> (+0.02%) ⬆️
...erinalang/util/diagnostic/DiagnosticErrorCode.java 99.83% <100.00%> (+<0.01%) ⬆️

... and 811 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaryamZi
Copy link
Member

MaryamZi commented Nov 2, 2022

@SasinduDilshara, please resolved the conflicts.

MaryamZi
MaryamZi reviewed Nov 16, 2022
View reviewed changes
Copy link
Member

@MaryamZi MaryamZi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the last commit message to start with an uppercase letter.

...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Stale label Jun 29, 2023
@pcnfernando
Copy link
Member

@SasinduDilshara Please resolve the conflicts

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Aug 7, 2023
@pcnfernando pcnfernando merged commit c9c65ef into ballerina-platform:master Aug 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcnfernando pcnfernando pcnfernando approved these changes

@LakshanWeerasinghe LakshanWeerasinghe LakshanWeerasinghe approved these changes

@sameerajayasoma sameerajayasoma Awaiting requested review from sameerajayasoma sameerajayasoma is a code owner

@hasithaa hasithaa Awaiting requested review from hasithaa hasithaa is a code owner

@rdulmina rdulmina Awaiting requested review from rdulmina

@SandaruJayawardana SandaruJayawardana Awaiting requested review from SandaruJayawardana

@gimantha gimantha Awaiting requested review from gimantha gimantha is a code owner

@IMS94 IMS94 Awaiting requested review from IMS94

@MaryamZi MaryamZi Awaiting requested review from MaryamZi MaryamZi is a code owner

@hevayo hevayo Awaiting requested review from hevayo

@KavinduZoysa KavinduZoysa Awaiting requested review from KavinduZoysa KavinduZoysa is a code owner

Assignees

@KavinduZoysa KavinduZoysa

Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
No open projects
Compiler Core Pull Requests
Status: Addressing Review Suggestions
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler crashes when a union is used within multiple wait
6 participants
@SasinduDilshara @MaryamZi @KavinduZoysa @pcnfernando @LakshanWeerasinghe @gimantha