Validate expr with check keyword in call stmt #29282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiranSachintha
added
the
Team/CompilerFE
chiranSachintha
force-pushed
the
issue-28769
branch
from
f550bac
to
d3fc5b3
Compare
...er/ballerina-parser/src/main/java/io/ballerina/compiler/internal/parser/BallerinaParser.java
Outdated
Show resolved
Hide resolved
...ina-parser/src/main/java/io/ballerina/compiler/internal/diagnostics/DiagnosticErrorCode.java
Outdated
Show resolved
Hide resolved
rdulmina
reviewed
Mar 25, 2021
...ina-parser/src/main/java/io/ballerina/compiler/internal/diagnostics/DiagnosticErrorCode.java
Outdated
Show resolved
Hide resolved
rdulmina
reviewed
Mar 25, 2021
...er/ballerina-parser/src/main/java/io/ballerina/compiler/internal/parser/BallerinaParser.java
Outdated
Show resolved
Hide resolved
rdulmina
reviewed
Mar 25, 2021
...er/ballerina-parser/src/main/java/io/ballerina/compiler/internal/parser/BallerinaParser.java
Outdated
Show resolved
Hide resolved
rdulmina
reviewed
Mar 26, 2021
...er/ballerina-parser/src/main/java/io/ballerina/compiler/internal/parser/BallerinaParser.java
Show resolved
Hide resolved
rdulmina
reviewed
Mar 26, 2021
...er/ballerina-parser/src/main/java/io/ballerina/compiler/internal/parser/BallerinaParser.java
Show resolved
Hide resolved
chiranSachintha
force-pushed
the
issue-28769
branch
from
ebdf599
to
ceb3358
Compare
Codecov Report
@@ Coverage Diff @@
## master #29282 +/- ##
============================================
+ Coverage 66.77% 68.09% +1.31%
- Complexity 34220 35275 +1055
============================================
Files 2800 2816 +16
Lines 150969 152586 +1617
Branches 18251 18534 +283
============================================
+ Hits 100813 103902 +3089
+ Misses 44161 42528 -1633
- Partials 5995 6156 +161 Continue to review full report at Codecov.
|
...ina-parser/src/main/java/io/ballerina/compiler/internal/diagnostics/DiagnosticErrorCode.java
Outdated
Show resolved
Hide resolved
hasithaa
reviewed
Mar 26, 2021
| "operator: all expression types are equivalent to error type", 16, 25); | ||
| BAssertUtil.validateError(compile, 2, "invalid usage of the 'check' expression " + | ||
| "operator: all expression types are equivalent to error type", 30, 25); | ||
| BAssertUtil.validateError(compile, 1, "incompatible types: expected 'string', found 'never'", 16, 19); |
There was a problem hiding this comment.
Example is here is
function testCheckedExprSemanticErrors2() returns error? {
string line = checkpanic readLineError();
}
The diagnostic is correct, But I think we can improve this.
There was a problem hiding this comment.
@hasithaa Shall I fix this in a separate PR?
There was a problem hiding this comment.
yes. Please create an issue, we can fix this later.
There was a problem hiding this comment.
Created.(#29696)
MaryamZi
reviewed
Mar 26, 2021
compiler/ballerina-parser/src/main/resources/syntax_diagnostic_message.properties
Outdated
Show resolved
Hide resolved
hasithaa
reviewed
Mar 26, 2021
...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
Show resolved
Hide resolved
chiranSachintha
force-pushed
the
issue-28769
branch
from
cfa4b2e
to
c4375ab
Compare
MaryamZi
reviewed
Mar 26, 2021
| @@ -431,7 +431,6 @@ | |||
|
|
|||
| // Checked expression related errors | |||
| CHECKED_EXPR_INVALID_USAGE_NO_ERROR_TYPE_IN_RHS("BCE3030", "checked.expr.invalid.usage.no.error.type.rhs"), | |||
| CHECKED_EXPR_INVALID_USAGE_ALL_ERROR_TYPES_IN_RHS("BCE3031", "checked.expr.invalid.usage.only.error.types.rhs"), | |||
There was a problem hiding this comment.
Shall we fix the subsequent diagnostic IDs?
There was a problem hiding this comment.
Shall we update this later, This might conflict with other PRs.
MaryamZi
reviewed
Mar 26, 2021
MaryamZi
approved these changes
Mar 26, 2021
This was referenced Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #28769
Check List