-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify object method scope and object field scope #25966
Merged
hasithaa
merged 11 commits into
ballerina-platform:master
from
rdhananjaya:unify-obj-method-field-scopes
Oct 20, 2020
Merged
Unify object method scope and object field scope #25966
hasithaa
merged 11 commits into
ballerina-platform:master
from
rdhananjaya:unify-obj-method-field-scopes
Oct 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into unify-obj-method-field-scopes
… into unify-obj-method-field-scopes
rdhananjaya
added
the
Team/CompilerFE
All issues related to Language implementation and Compiler, this exclude run times.
label
Sep 21, 2020
… into unify-obj-method-field-scopes
… into unify-obj-method-field-scopes � Conflicts: � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/interop/JMethodResolver.java
… into unify-obj-method-field-scopes � Conflicts: � language-server/modules/langserver-core/src/main/java/org/ballerinalang/langserver/common/utils/FilterUtils.java � language-server/modules/langserver-core/src/main/java/org/ballerinalang/langserver/signature/SignatureHelpUtil.java � tests/ballerina-compiler-api-test/src/test/java/io/ballerina/semantic/api/test/SymbolLookupTest.java
hasithaa
reviewed
Oct 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
hasithaa
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team/CompilerFE
All issues related to Language implementation and Compiler, this exclude run times.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
With this change, we can extract out object methods as standalone functions, the receiver will be stored as a closure variable.
Fixes #25769
Approach
Samples
Remarks
Check List