New Table implementation #22874
Merged
New Table implementation #22874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initial table type compiler side implementation
Add table constructor initial implementation
[Table type] Make key-constraint as optional
Add improvements related to table access expression
…ina-lang into new-table-build-fix # Conflicts: # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmTypeGen.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/parser/antlr4/BallerinaLexer.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/parser/antlr4/BallerinaLexer.tokens # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/parser/antlr4/BallerinaParser.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/parser/antlr4/BallerinaParser.tokens # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SymbolResolver.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java # compiler/ballerina-lang/src/main/resources/grammar/BallerinaLexer.g4
Multikey index support for table + Test case fixes
…m/ballerina-lang into new-table-build-fix
…ina-lang into new-table-build-fix
…na-lang into mohanvive-new-table-impl-2 # Conflicts: # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/Types.java
Fix type param issue
gimantha
reviewed
Apr 29, 2020
bvm/ballerina-runtime/src/main/java/org/ballerinalang/jvm/TypeChecker.java
Outdated
Show resolved
Hide resolved
mohanvive
commented
Apr 29, 2020
bvm/ballerina-runtime/src/main/java/org/ballerinalang/jvm/values/TableValueImpl.java
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/org/ballerinalang/jvm/values/TableValueImpl.java
Show resolved
Hide resolved
...lerina-lang/src/main/java/org/ballerinalang/model/tree/expressions/IndexBasedAccessNode.java
Outdated
Show resolved
Hide resolved
compiler/ballerina-lang/src/main/java/org/ballerinalang/model/tree/types/TableTypeNode.java
Outdated
Show resolved
Hide resolved
compiler/ballerina-lang/src/main/java/org/ballerinalang/model/types/TableType.java
Outdated
Show resolved
Hide resolved
compiler/ballerina-lang/src/main/java/org/ballerinalang/util/diagnostic/DiagnosticCode.java
Outdated
Show resolved
Hide resolved
...r/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/Types.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/wso2/ballerinalang/compiler/tree/expressions/BLangTableConstructorExpr.java
Outdated
Show resolved
Hide resolved
...g/src/main/java/org/wso2/ballerinalang/compiler/tree/expressions/BLangTableMultiKeyExpr.java
Show resolved
Hide resolved
...lerina-lang/src/main/java/org/wso2/ballerinalang/compiler/tree/types/BLangTableTypeNode.java
Show resolved
Hide resolved
pcnfernando
reviewed
Apr 29, 2020
langlib/lang.table/src/main/java/org/ballerinalang/langlib/table/GetKeys.java
Outdated
Show resolved
Hide resolved
pcnfernando
reviewed
Apr 29, 2020
langlib/lang.table/src/main/java/org/ballerinalang/langlib/table/HasKey.java
Show resolved
Hide resolved
pcnfernando
reviewed
Apr 29, 2020
langlib/lang.table/src/main/java/org/ballerinalang/langlib/table/ToArray.java
Outdated
Show resolved
Hide resolved
Add modifications as per review comments
…m/ballerina-lang into new-table-impl-2
Do code review fixes
gimantha
approved these changes
Apr 30, 2020
This was referenced Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Check List