Remove table type and dependent usages #22284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ina-lang into master-new # Conflicts: # language-server/modules/langserver-core/src/main/java/org/ballerinalang/langserver/common/utils/FunctionGenerator.java
mohanvive
changed the title
|
As you aware, there is a proposal for new Table implementation [1]. Due to this, we have to remove the existing table implementation and JDBC connector (depends on old table impl). This PR, removes table type, old jdbc impl and related depend changes. Also, table type usage in other test cases are commented (with TODO flag) for the future need. |
mohanvive
requested review from
nadeeshaan,
wggihan,
gimantha,
grainier,
hasithaa and
pcnfernando
…ina-lang into master-new # Conflicts: # language-server/modules/langserver-core/src/test/resources/completion/toplevel/allTopLevelItemSkip.json
grainier
approved these changes
Mar 31, 2020
gimantha
approved these changes
Mar 31, 2020
nadeeshaan
reviewed
Mar 31, 2020
There was a problem hiding this comment.
@mohanvive
Shall we create an issue to track the disabled test cases for this particular change
Remove obsolete table related classes
|
|
There are a considerable amount of test cases. Let me create an issue for this. |
daneshk
approved these changes
Mar 31, 2020
This was referenced Mar 31, 2020
…ina-lang into master-new # Conflicts: # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeParamAnalyzer.java
hasithaa
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Check List