Fix several issues with object type reference #18404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into obj-reference-fixes
MaryamZi
added
the
Team/CompilerFE
Codecov Report
@@ Coverage Diff @@
## master #18404 +/- ##
=======================================
Coverage 14.82% 14.82%
=======================================
Files 48 48
Lines 1268 1268
Branches 201 201
=======================================
Hits 188 188
Misses 1066 1066
Partials 14 14Continue to review full report at Codecov.
|
hasithaa
approved these changes
Sep 2, 2019
| @@ -1688,6 +1690,7 @@ private void createDummyTypeDefSymbol(TypeDefinition typeDefNode, SymbolEnv env) | |||
|
|
|||
| private void resolveReferencedFields(BLangStructureTypeNode structureTypeNode, SymbolEnv typeDefEnv) { | |||
| List<BSymbol> referencedTypes = new ArrayList<>(); | |||
| List<BLangType> invalidTypeRefs = new ArrayList<>(); | |||
| // Get the inherited fields from the type references | |||
| structureTypeNode.referencedFields = structureTypeNode.typeRefs.stream().flatMap(typeRef -> { | |||
There was a problem hiding this comment.
Btw, This is not a good stream implementation. we should refactor this later.
| } | ||
|
|
||
| BObjectType objectType = (BObjectType) referredType; | ||
| if (structureTypeNode.type.tsymbol.owner != referredType.tsymbol.owner) { |
There was a problem hiding this comment.
There can be scenario, this logic fails, Like, local type def. Better to validate pkg, instated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title.
Fixes #17920 Referencing objects with fields/methods with module level visibility is not restricted across modules
Fixes #18370 No validation for function param visibility match when referencing objects
Fixes #13822 Referencing two abstract objects which both have a method with the same signature does not cause a compilation error
Fixes #18402 Object type reference attempts copying methods of invalid references
Approach
Samples
Remarks
Check List