Refactor Modules for Inbound Authentication #15435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bhashinee
reviewed
May 29, 2019
Bhashinee
reviewed
May 29, 2019
…ina-lang into refactor-modules-for-inbound-auth
praneesha
reviewed
May 31, 2019
ayomawdb
approved these changes
May 31, 2019
ayomawdb
requested changes
May 31, 2019
…ina-lang into refactor-modules-for-inbound-auth
Co-Authored-By: praneesha <praneesha@wso2.com> Co-Authored-By: Bhashinee <Bhashinee@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #15435 +/- ##
=========================================
Coverage ? 43.59%
Complexity ? 5393
=========================================
Files ? 983
Lines ? 38012
Branches ? 5727
=========================================
Hits ? 16571
Misses ? 19579
Partials ? 1862Continue to review full report at Codecov.
|
ayomawdb
approved these changes
May 31, 2019
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The current
ballerina/authmodule has implementation related to Config Auth Store, JWT, LDAP etc. So, with this PR,ballerina/jwtandballerina/ldapmodules are newly created. Please refer to the discussion @ballerina-dev [1].Also, the HTTP authn handlers were renamed in a generic manner as follows:
http:JwtAuthnHandlerhttp:BearerAuthHeaderAuthnHandlerhttp:BasicAuthnHandlerhttp:BasicAuthHeaderAuthnHandler[1] https://groups.google.com/d/msg/ballerina-dev/7SYDiKeF8p8/3GNncS9dAwAJ
Fixes #15385
Check List