Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable support for using mapping constructors with record binding patterns #19804

Closed
pubudu91 opened this issue Nov 6, 2019 · 0 comments · Fixed by #40283
Closed

Re-enable support for using mapping constructors with record binding patterns #19804

pubudu91 opened this issue Nov 6, 2019 · 0 comments · Fixed by #40283
Assignees
@dulajdilshan
Labels
Area/TypeChecker Type Checker related issues #Compiler Lang/BindingPatterns Planning/SwanLakeDump All issues planned for Swan Lake GA release Priority/High Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Type/Improvement Type/SpecDeviation

Comments

@pubudu91
Copy link
Contributor

pubudu91 commented Nov 6, 2019

Support for using record binding patterns with mapping constructors was removed with 0090467

Need to re-enable this. I had a quick look at this, with the check added here to disable the support removed. It seems to be working. Need to test more and re-enable.
@pubudu91 pubudu91 added Type/Improvement Area/Compiler Type/SpecDeviation Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. labels Nov 6, 2019
@pubudu91 pubudu91 added this to the Ballerina 1.0.x milestone Nov 6, 2019
@pubudu91 pubudu91 changed the title Re-enable support for mapping constructors with record binding patterns Re-enable support for using mapping constructors with record binding patterns Nov 6, 2019
@pubudu91 pubudu91 mentioned this issue Nov 13, 2019
Merged
14 tasks
@hasithaa hasithaa removed this from the Ballerina 1.0.x milestone Apr 25, 2020
@MaryamZi MaryamZi mentioned this issue Mar 15, 2021
Closed
@hasithaa hasithaa added Planning/SwanLakeDump All issues planned for Swan Lake GA release and removed CompilerSLDump labels Mar 16, 2021
@MaryamZi MaryamZi mentioned this issue Apr 1, 2021
Open
@gimantha gimantha closed this as completed Mar 2, 2023
@dulajdilshan dulajdilshan reopened this Apr 24, 2024
@dulajdilshan dulajdilshan self-assigned this Apr 24, 2024
This was referenced Apr 24, 2024
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dulajdilshan dulajdilshan

Labels
Area/TypeChecker Type Checker related issues #Compiler Lang/BindingPatterns Planning/SwanLakeDump All issues planned for Swan Lake GA release Priority/High Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Type/Improvement Type/SpecDeviation
Projects
Ballerina Team Main Board
Archived in project
Milestone
No milestone
4 participants
@hasithaa @pubudu91 @gimantha @dulajdilshan