Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide completions for expressions in the expression editor #403

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

nipunayf
Copy link
Contributor

@nipunayf nipunayf commented Sep 14, 2024

Description

Since the expression editor lacks access to the source code, it cannot retrieve completions from the text document. To address this, a LS API, expressionEditor/completions, appends changes to a temporary project to obtain the necessary completions.

Remarks

Duplicating the project introduces significant complexity in terms of both performance and memory, as it duplicates memory usage and involves many I/O operations. Therefore, we should explore an approach where the expression editor retrieves completions from the original project. This would be feasible if the state in which the user uses the expression editor does not trigger the other APIs.

@nipunayf nipunayf added the Area/FlowModel Related to the flow model generation LS extension label Sep 14, 2024
@hasithaa
Copy link

@sachiniSam Do we need more functionalities for the expression editor?

@nipunayf nipunayf merged commit 1e628b7 into ballerina-platform:flow_model Sep 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/FlowModel Related to the flow model generation LS extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants