Release v1.2.1

[jhermsmeier]

PR Checklist:

• Bump the version number in the package.json's version property
• Bump the version number in the npm-shrinkwrap.json's version property
• Add a new entry to CHANGELOG.md by running make changelog
• Re-take screenshot.png so it displays the latest version in the bottom
  right corner
• Revise the updates.semverRange version in package.json

Release Checklist:

• Manual regression testing
• Merge this
• Tag the commit on master
• Publish the draft release
• Publish packages on Bintray
• Publish packages on S3
• Forum post
• Update Etcher website
• Mailing List update

[jhermsmeier]

@jviotti mind taking that high-res screenshot again? :)

[lurch]

Huh? According to https://github.com/resin-io/etcher/commits/master this was a feature in v1.2.0 ??

[jhermsmeier]

That's because the release branch itself was only merged after; but that definitely didn't end up in v1.2.0

[jviotti]

[jviotti]

@jhermsmeier Looks like you should get yourself a company brand new Retina MacBook Pro, for "screenshooting" purposes :P

[lurch]

...or you could just write a little ImageMagick script to programatically redraw the version number in the bottom-right corner of the current screenshot ;-)

[lurch]

Publish the draft release
Publish packages on S3

If we want to 'fix' #1893 with Etcher v1.2.1 (I don't think there's any reason not to?), then you just need to make this change locally

--- a/Makefile
+++ b/Makefile
@@ -423,6 +423,7 @@ TARGETS +=  \
        electron-installer-redhat \
        cli-installer-tar-gz
 PUBLISH_AWS_S3 += \
+       $(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(TARGET_ARCH_APPIMAGE).AppImage \
        $(BUILD_DIRECTORY)/$(APPLICATION_NAME_LOWERCASE)-$(APPLICATION_VERSION)-$(PLATFORM)-$(TARGET_ARCH_APPIMAGE).zip \
        $(BUILD_DIRECTORY)/$(APPLICATION_NAME)-cli-$(APPLICATION_VERSION)-$(PLATFORM)-$(TARGET_ARCH).tar.gz
 PUBLISH_BINTRAY_DEBIAN += \

before running make publish-aws-s3 (and I'll make the corresponding change to #1896 ). And then remember to also add the unzipped AppImages to the draft GitHub release.
EDIT: Aha, I see you've already done the last part :)

[jhermsmeier]

@lurch why would we need to publish the AppImages to S3 as well?

[lurch]

I don't think there's any real reason, it just feels more consistent. And if we add the change to the Makefile, then future snapshot uploads of Etcher will also have the unzipped AppImages available (since the snapshot releases currently only go to S3)

[jviotti]

...or you could just write a little ImageMagick script to programatically redraw the version number in the bottom-right corner of the current screenshot ;-)

We could do this with a small Spectron script btw

[jviotti]

Can we remove the trailing period here?

[jhermsmeier]

Done

[lurch]

Oh, I assumed that the CHANGELOG.md was only auto-generated by versionist, and there was no scope for hand-editing it? If we are "allowed" to hand-edit it, then I'd suggest removing "Add a sudo-prompt upon launch on Linux-based systems." as that change actually got reverted when we removed the Linux usbboot support, and it never made it into a published version of Etcher.

[jviotti]

Left one small comments regarding the CHANGELOG, but looks good otherwise

[lurch]

We could do this with a small Spectron script btw

I wonder if Spectron supports emulating high-res Retina displays?