Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: Mark removed languages + distros as EOL #3008

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Iznogohul
Copy link
Contributor

@Iznogohul Iznogohul commented Jun 21, 2024

Update docs to reflect the changes of these pull requests
balena-io/contracts#421
balena-io/contracts#422
balena-io/contracts#423

  • added jdk 17 in the supported language stacks

@Iznogohul
Copy link
Contributor Author

@vipulgupta2048 does this look ok to you?

Copy link
Member

@vipulgupta2048 vipulgupta2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR. An update to this page is long due. Found some corrections if you can make them, we have to work towards automating this page completely but haven;t been able to reach that goal.

Some of these versions of balena base images might not even exist as well.

- [Ubuntu](https://www.ubuntu.com/): xenial (16.04), bionic (18.04), focal (20.04), impish (21.10), kinetic (22.10) and jammy (22.04)
- [Fedora](https://getfedora.org/): 36, 37 and 38
- [Ubuntu](https://www.ubuntu.com/): xenial (16.04), bionic (18.04), focal (20.04), impish (21.10) (EOL), kinetic (22.10) (EOL) , jammy (22.04) and lunar (23.04) (EOL)
- [Fedora](https://getfedora.org/): 36 (EOL), 37 and 38
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems, 37 and 38 are EOL as well: https://endoflife.date/fedora

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mark them as EOL because contacts continues building them even though they are EOL. Do you need to mark them as EOL based on the https://endoflife.date/fedora and not reflect the contracts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for mentioning that, we definitely don't want to list versions we aren't building anymore. I have already figured out a way to automate this page, but I have been busy with something. Would be able to take this on next sprint, automate this page and maybe we can add the EOL notices automatically as a stretch feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vipulgupta2048 Ok so for all the versions that their contract have been removed (i.e nodejs 16.19.1) balena-io/contracts#421 should i change the docs and remove them completly? Right now my proposed patch doesn't seem to follow what you are describing or should we wait for the automation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding that out. Indeed, let's wait for the automation. I will be able to work on after 2 weeks as our current work cycle ends and we bet on this work since there are a lot of moving parts to get this page automated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. So @vipulgupta2048 will leave this open till the merge of the automation finish just for reference.Feel free to close it when the automation is done or mention me to mark it as closed.

@@ -19,18 +19,19 @@ excerpt: Docker images maintained by balena
- Multiple Distributions:
- [Debian](https://www.debian.org/): buster (10), bullseye (11), bookworm (12) and sid
- [Alpine](https://alpinelinux.org/): 3.12, 3.13, 3.14, 3.15, 3.16, 3.17 and edge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Alpine](https://alpinelinux.org/): 3.12, 3.13, 3.14, 3.15, 3.16, 3.17 and edge
- [Alpine](https://alpinelinux.org/): 3.12, 3.13, 3.14, 3.15, 3.16, 3.17 and edge

If you can, can you please update the other entries as well! https://endoflife.date/alpine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sure no problem

Update docs to reflect the changes of these pull requests
balena-io/contracts#421
balena-io/contracts#422
balena-io/contracts#423
+ added jdk 17 in the supported language stacks
@Iznogohul
Copy link
Contributor Author

@vipulgupta2048 Did the changes that you asked + checked for more languages and distros from https://endoflife.date.
I can't know for sure what images doesn't exist but could help with the automation of the doc generation if that would be possible. Endoflife has a simple api that would be useful here.

@Iznogohul Iznogohul changed the title patch: Mark remove languages + distros as EOL patch: Mark removed languages + distros as EOL Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants