Add File Manager #19
Merged
Add File Manager #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggie44
force-pushed
the
filemanager
branch
from
c44cb89
to
566b356
Compare
maggie44
force-pushed
the
filemanager
branch
2 times, most recently
from
d9fa9c6
to
415e9c5
Compare
maggie44
force-pushed
the
filemanager
branch
from
0e380a5
to
b1e8524
Compare
|
File manager?! SICK!!! what a good idea, this is super useful. I see the need to refactor i18n for this, you are right it's better to get it in now than deal with merge conflicts for sure |
nucleardreamer
approved these changes
Feb 20, 2022
|
@Maggie0002 I tested the file manager feature. Incredible work! |
This would probably be a good auth implementation if you were able to have a go: https://www.passportjs.org/tutorials/password / https://www.passportjs.org/packages/passport-local/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[X] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Add a file manager, initially to be used as a Volume Manager. The idea is you can mount volumes in to the specified directory then browse them, upload, delete etc. to allow management of the content of volumes from different containers on the device.
This isn't a needed or priority features, but up until now I have basically just been porting over stuff I have already done elsewhere and integrating it here. I think this is probably the last thing I have to go in, so can expect the pace of this week to slow quite a bit now.
Which issue (if any) does this pull request address?
A useful file manager for a range of tasks for users, but for now implemented as a means of navigating the content of volumes via the UI.
Is there anything you'd like reviewers to focus on?
I'm afraid this pull request entails another refactor, this time of the i18n integration and strings. I am hoping to get this merged ASAP then work on it from the main branch like the other things. In the meantime, be wary of merge conflicts that could occur with your other branches.