Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for raw query streaming #289

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PillowPillow
Copy link

Hi, like some other peoples, i guess, i needed to stream the result of raw queries.
This pr gives the possibility to perform streaming from raw query by using the where.id criteria if he match the query regex.

I created a temporary adapter for my own usage during this PR or if you don't want to merge it.
https://www.npmjs.com/package/sails-mysql-pillow

Best regards,
Nicolas

@zivc
Copy link

zivc commented Mar 21, 2016

+1 for this.

@zivc
Copy link

zivc commented Mar 21, 2016

Problem, your regex makes the query have to contain SELECT * FROM. Not all queries (especially in enterprise development) can exist like this. Some start with SET, SHOW etc.

Removing the regex or expecting a query param of the options object would be preferable for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants