Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an issue with forgetting to unlock #430

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Conversation

mengqingzhong
Copy link
Contributor

这里好像忘了放锁,可能导致系统卡住。
其中一个可能卡住的点是:由于这里没有放锁,导致check_dead_nodes卡住(拿不到replicator的锁);但是check_dead_nodes已经在handle_stepdown_timeout持有braft::NodeImpl::_mutex。进而导致后续所有需要拿braft::NodeImpl::_mutex的地方都被卡住。整个Node不可用。

@mengqingzhong mengqingzhong mentioned this pull request Dec 25, 2023
@PFZheng PFZheng merged commit 83821c2 into baidu:master Dec 28, 2023
4 checks passed
@mengqingzhong mengqingzhong deleted the unlock branch December 31, 2023 16:31
@ergesun ergesun mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants