Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the parameter order of time_cnn in ARM convolution bench #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaidTw
Copy link

@jaidTw jaidTw commented Apr 25, 2021

Hi, I was looking at the code of convolution benchmark on ARM, and found the calling order and declaration order of parameters of time_cnn does not match. I believe the order of 'c' and 'n' should be exchanged.

Declaration:

int time_cnn(unsigned int w, unsigned int h, unsigned int n, unsigned int c, 
             unsigned int k, unsigned int filter_w, int filter_h,
             unsigned int pad_w, unsigned int pad_h, 
             unsigned int wstride, unsigned int hstride,

Calling:

auto time = time_cnn(w, h, c, n, k, filter_w, filter_h, pad_w, pad_h, wstride, hstride, num_repeats);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant