Refactor/clone #54
Merged
Refactor/clone #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is refactoring Hooper and slide components, to handle slides clone better, and enhance performance, with no breaking changes.
Summary
The cloning process is done in the
createdlife cycle hook, by clone each slide vNode object, then pass it to the slots array. hereEach slide now can internally update its width/height and state, based on the current active slide.
Motivation
The old way was including access DOM a lot, each Hooper slider created, and when Hooper is updated.
Clondninig DOM nodes using
cloneNode()will only clone the node markup and will not save its event listeners (#49)This old way forced us to update slide state (active/prev/next) using
classList, and its width/heightstylewhich is not efficient.closes #49