Set static previews for [jenkins jenkinsplugin] and tweak tests #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
added
the
service-badge
|
paulmelnikow
commented
Jan 15, 2019
| @@ -16,42 +16,10 @@ t.create('total installs | valid') | |||
| }) | |||
| ) | |||
|
|
|||
| t.create('total installs | invalid: no "installations" property') | |||
There was a problem hiding this comment.
These tests are basically testing Joi and BaseService and don't seem necessary. We can trust that Joi and BaseService are rejecting objects which do not match the schema without adding more tests for them.
calebcartwright
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.