-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showcase two of our distinguishing features #2705
Conversation
|
@@ -3,13 +3,16 @@ | |||
height="130"> | |||
</p> | |||
<p align="center"> | |||
<a href="https://github.com/badges/shields/graphs/contributors" alt="Contributors"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More general comment, but what do you think about grouping the badges in separate buckets vs all back to back? For example we could have one line (or paragraph) for activity related badges (contributors, commits, sponsors, backers), another line for dev/code metrics (build status, code coverage, service test status, lgtm alerts), and another line for the social badges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that does end up taking up a lot more vertical real estate so not crazy about that 🤔 I just get used to locating a badge (like coverage or service tests in particular) in a particular location and was trying to think of a way they wouldn't jump around so much when we add new badges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are getting a little bit into https://twitter.com/NikolayTalanov/status/860444084594393088 territory 😁
We could group them into different sections in the readme, like put stuff related to community participation in one place, and stuff related to quality in another. It could be worth having a "maintainers dashboard" in one of the other readme files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that gave me a good chuckle. I like the idea of a maintainers view too. The ones I check the most are the coverage and build/service test status so would be nice to have somewhere to find those quickly.
# Conflicts: # README.md
… to brightgreen See examples in #2705 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two badges are definitely worth adding, and the current format looks better than what I was thinking so 👍 for me
Vaguely on topic:
brightgreen
.