Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert some static previews [bugzilla buildkite bundlephobia cookbook liberapay luarocks] #2652

Merged
merged 4 commits into from
Jan 6, 2019
Merged

Convert some static previews [bugzilla buildkite bundlephobia cookbook liberapay luarocks] #2652

merged 4 commits into from
Jan 6, 2019

Conversation

paulmelnikow
Copy link
Member

No description provided.

@paulmelnikow paulmelnikow added service-badge Accepted and actionable changes, features, and bugs blocker PRs and epics which block other work labels Jan 6, 2019
@shields-ci
Copy link

shields-ci commented Jan 6, 2019 •
edited
Loading

Warnings
⚠️ This PR modified service code for bugzilla but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for buildkite but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bundlephobia but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cookbook but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for liberapay but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for luarocks but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against eac6baf

chris48s
chris48s reviewed Jan 6, 2019
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor typo to fix and we're good to go

services/buildkite/buildkite.service.js Outdated
pattern: ':identifier/:branch',
namedParams: {
identifier: '3826789cf8890b426057e6fe1c4e683bdf04fa24d498885489',
branch: 'mater',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "master"

@paulmelnikow
Copy link
Member Author

Thanks for reviewing!

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2652 January 6, 2019 21:28 Inactive
@paulmelnikow paulmelnikow merged commit b32f6ea into master Jan 6, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the static-previews branch January 6, 2019 22:39
@paulmelnikow paulmelnikow mentioned this pull request Jan 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s left review comments

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
blocker PRs and epics which block other work service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulmelnikow @shields-ci @chris48s @calebcartwright