Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[librariesio] Missing try/catch block and tests #1644

Merged
merged 3 commits into from
Apr 14, 2018
Merged

[librariesio] Missing try/catch block and tests #1644

merged 3 commits into from
Apr 14, 2018

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Apr 13, 2018

This pull request should close #1621 by adding our usual try/catch block. There weren't any tests for this service, so I implemented a simple test suite (one extra box ticked in #1358! 👍 ) and also got rid of the var keyword in favour of more appropriate identifiers.

@PyvesB PyvesB added service-badge Accepted and actionable changes, features, and bugs sentry Bugs found using Sentry labels Apr 13, 2018
@shields-ci
Copy link

shields-ci commented Apr 13, 2018 •
edited
Loading

Messages
📖

✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS

platan
platan approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@platan platan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PyvesB Thanks, this looks great!

server.js Outdated

request(options, function(err, res, json) {

if (err || res.statusCode !== 200) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to improve error handling by using

shields/lib/error-helper.js

Line 8 in e1755df

const checkErrorResponse = function(badgeData, err, res, notFoundMessage = 'not found') {

in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks for reviewing!

RedSparr0w
RedSparr0w approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@RedSparr0w RedSparr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@PyvesB PyvesB merged commit ac13fdb into badges:master Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platan platan platan approved these changes

@RedSparr0w RedSparr0w RedSparr0w approved these changes

Assignees
No one assigned
Labels
sentry Bugs found using Sentry service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash in librariesio
4 participants
@PyvesB @shields-ci @platan @RedSparr0w