Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 730 #743

Merged
merged 36 commits into from
Jul 29, 2024
Merged

Fix issue 730 #743

merged 36 commits into from
Jul 29, 2024

Conversation

teddychao
Copy link
Contributor

@teddychao teddychao commented Jul 16, 2024

Fixes #730.

Changes proposed in this pull request:

  • Update pspm_help to make it able to read help text from source code.
  • Update help text for functions.

After testing, almost all the functions can be read, with a few exceptions as following

  • pspm_get_timing: Arguments are written in a different method.
  • pspm_jobman: The symbol → is not read by pspm_help.
  • pspm_load_channel: Arguments are not sorted conventionally.
  • pspm_load_data: Arguments are not sorted conventionally.
  • pspm_process_illuminance: There are second-level subfields.
  • pspm_pupil_pp_options: Arguments are not sorted conventionally.
  • pspm_tam: There are second-level subfields.

@teddychao teddychao linked an issue Jul 16, 2024 that may be closed by this pull request
@teddychao
Copy link
Contributor Author

It can generate the struct now but have not sorted subfields. Will do next

image

@teddychao teddychao self-assigned this Jul 18, 2024
@teddychao teddychao added the In Progress Currently being worked on label Jul 18, 2024
@teddychao
Copy link
Contributor Author

Example

image

@teddychao
Copy link
Contributor Author

Example 2
image

@teddychao teddychao linked an issue Jul 22, 2024 that may be closed by this pull request
@teddychao teddychao marked this pull request as ready for review July 29, 2024 05:30
@teddychao teddychao added Completed & Waiting for Review Completed and waiting for review and removed In Progress Currently being worked on labels Jul 29, 2024
@teddychao teddychao marked this pull request as draft July 29, 2024 05:35
@teddychao teddychao marked this pull request as ready for review July 29, 2024 05:52
@dominikbach dominikbach added Approved The pull request has been approved and can be checked and then merged. and removed Completed & Waiting for Review Completed and waiting for review labels Jul 29, 2024
@teddychao teddychao merged commit dab38bd into develop Jul 29, 2024
1 check passed
@teddychao teddychao deleted the 730-improving-pspm_help branch July 29, 2024 11:07
@teddychao teddychao restored the 730-improving-pspm_help branch July 29, 2024 11:07
@teddychao teddychao deleted the 730-improving-pspm_help branch July 29, 2024 11:07
@teddychao teddychao removed the Approved The pull request has been approved and can be checked and then merged. label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving pspm_help Improve help text and input checking in pspm_sf_... subfunctions.
2 participants