Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable code coverage #474

Merged
merged 4 commits into from
Mar 14, 2017
Merged

Conversation

oleksandr-kuzmenko
Copy link
Contributor

@oleksandr-kuzmenko oleksandr-kuzmenko commented Mar 10, 2017

I propose to add code coverage to this repo.
Can someone from members enable integration with codecov.io (and then restart CI)?

@boopathi boopathi added the Tag: Internal Pull Request changing project internals - code that is NOT published label Mar 10, 2017
package.json Outdated
@@ -14,7 +14,8 @@
"test": "jest",
"build": "gulp build",
"watch": "gulp watch",
"ci": "npm run lint && npm run bootstrap && jest"
"ci": "npm run lint && npm run bootstrap && jest --coverage && codecov -f coverage/coverage-final.json",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run cov instead of jest --coverage

@oleksandr-kuzmenko oleksandr-kuzmenko changed the title Enable code coverage [WIP] Enable code coverage Mar 10, 2017
@oleksandr-kuzmenko oleksandr-kuzmenko changed the title [WIP] Enable code coverage Enable code coverage Mar 10, 2017
@oleksandr-kuzmenko
Copy link
Contributor Author

@boopathi @hzoo can you please enable integration with codecov.io?

@hzoo
Copy link
Member

hzoo commented Mar 14, 2017

done

@codecov
Copy link

codecov bot commented Mar 14, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@ebb9f29). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #474   +/-   ##
=========================================
  Coverage          ?   82.25%           
=========================================
  Files             ?       35           
  Lines             ?     2462           
  Branches          ?      808           
=========================================
  Hits              ?     2025           
  Misses            ?      257           
  Partials          ?      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb9f29...79d0120. Read the comment docs.

@oleksandr-kuzmenko
Copy link
Contributor Author

[x] codecov/project — No report found to compare against

@hzoo it's OK for the first PR with codecov =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tag: Internal Pull Request changing project internals - code that is NOT published
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants