This repository has been archived by the owner on May 19, 2018. It is now read-only.
Increase test coverage #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
reviewed
Oct 14, 2016
| @@ -668,7 +668,6 @@ pp.parseClassBody = function (node) { | |||
|
|
|||
| method.static = isMaybeStatic && !this.match(tt.parenL); | |||
| if (method.static) { | |||
| if (isGenerator) this.unexpected(); | |||
There was a problem hiding this comment.
Yeah, method.static hinges on this.match(tt.name) and isGenerator (subsequently) on this.eat(tt.star). So they are mutually exclusive.
Current coverage is 96.05% (diff: 100%)@@ master #175 diff @@
==========================================
Files 19 19
Lines 3189 3169 -20
Methods 333 333
Messages 0 0
Branches 839 832 -7
==========================================
+ Hits 3016 3044 +28
+ Misses 94 65 -29
+ Partials 79 60 -19
|
…ssign, parseArrow
|
Holy crap, I wasn't aware we have so much dead code. I'm going to merge this now. |
kristofdegrave
pushed a commit
to kristofdegrave/babylon
that referenced
this pull request
Oct 27, 2016
* Increase test coverage * Test for error when binding `this` in destructuring pattern * Ignore coverage of inAsync check in parseAwait - already checked externally * Ignore coverage of default case in checkPropClash * Remove unused parameter isAsync from parseParenAndDistinguishExpression * Ignore coverage of an `else` branch in flowParseTypeParameterDeclaration * Flow: remove unused parameters to flowParseTypeAnnotatableIdentifier * Flow: ignore coverage of pass-through throw statement in parseConditional * Flow: Add test for error on property with type param * Flow: ignore coverage of pass-through throw statements in parseMaybeAssign, parseArrow * Add test for error on XML-style comment in module code * Update test for error on method in object pattern * Test for error: "Only '=' operator can be used for specifying default value"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intend to do a few of these - here's the first batch of new test cases written explicitly to hit previously uncovered lines/branches. I've also added one
// istanbul ignore nextand removed one line of dead code.EDIT: I've added a few more in the same vein. Anyone who wants to review and merge - tell me and I'll stop here and continue on another branch.