This repository has been archived by the owner on May 19, 2018. It is now read-only.
Fix duplicate check #137
Merged
Fix duplicate check #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
reviewed
Sep 22, 2016
| @@ -123,7 +123,7 @@ export default class State { | |||
|
|
|||
| // Names of exports store. `default` is stored as a name for both | |||
| // `export default foo;` and `export { foo as default };`. | |||
| exportedIdentifiers: {[id:string]: boolean}; | |||
| exportedIdentifiers: Array<string; | |||
|
cc @dlmr |
kaicataldo
approved these changes
Sep 22, 2016
|
Looks good! LGTM 👍 |
STRML
reviewed
Sep 22, 2016
| @@ -43,7 +43,7 @@ export default class State { | |||
| this.containsEsc = this.containsOctal = false; | |||
| this.octalPosition = null; | |||
|
|
|||
| this.exportedIdentifiers = {}; | |||
| this.exportedIdentifiers = []; | |||
There was a problem hiding this comment.
Any reason to not use Object.create(null); here instead?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix comment in #107
@kaicataldo Can you check if this is correct?