Disallow SpreadElement inside dynamic import (#529)

* Disallow SpreadElement inside dynamic import * tweak error message
babel · May 17, 2017 · dcef401 · dcef401
1 parent 23ff45f
commit dcef401
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/src/parser/expression.js b/src/parser/expression.js
@@ -314,8 +314,15 @@ export default class ExpressionParser extends LValParser {
         const node = this.startNodeAt(startPos, startLoc);
         node.callee = base;
         node.arguments = this.parseCallExpressionArguments(tt.parenR, possibleAsync);
-        if (node.callee.type === "Import" && node.arguments.length !== 1) {
-          this.raise(node.start, "import() requires exactly one argument");
+        if (node.callee.type === "Import") {
+          if (node.arguments.length !== 1) {
+            this.raise(node.start, "import() requires exactly one argument");
+          }
+
+          const importArg = node.arguments[0];
+          if (importArg && importArg.type === "SpreadElement") {
+            this.raise(importArg.start, "... is not allowed in import()");
+          }
         }
         base = this.finishNode(node, "CallExpression");
 

diff --git a/test/fixtures/experimental/dynamic-import/invalid-arguments-spread/actual.js b/test/fixtures/experimental/dynamic-import/invalid-arguments-spread/actual.js
@@ -0,0 +1 @@
+import(...[1])
diff --git a/test/fixtures/experimental/dynamic-import/invalid-arguments-spread/options.json b/test/fixtures/experimental/dynamic-import/invalid-arguments-spread/options.json
@@ -0,0 +1,3 @@
+{
+  "throws": "... is not allowed in import() (1:7)"
+}