Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Fix: allow options to be optional when monkey patching escope.analyze (fixes #470). #484

Merged
merged 1 commit into from
Jun 8, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ function monkeypatch(modules) {

var analyze = escope.analyze;
escope.analyze = function (ast, opts) {
opts = opts || {};
opts.ecmaVersion = eslintOptions.ecmaVersion;
opts.sourceType = eslintOptions.sourceType;
if (eslintOptions.globalReturn !== undefined) {
Expand Down
11 changes: 11 additions & 0 deletions test/babel-eslint.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
var assert = require("assert");
var babelEslint = require("..");
var espree = require("espree");
var escope = require("escope");
var util = require("util");
var unpad = require("dedent");

Expand Down Expand Up @@ -85,6 +86,16 @@ function parseAndAssertSame(code) {
}

describe("babylon-to-esprima", () => {
describe("compatibility", () => {
it("should allow ast.analyze to be called without options", function() {
var esAST = babelEslint.parse("`test`");

assert.doesNotThrow(() => {
escope.analyze(esAST);
}, TypeError, "Should allow no options argument.");
});
});

describe("templates", () => {
it("empty template string", () => {
parseAndAssertSame("``");
Expand Down