Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#156 Support torchmetrics #230

Merged
merged 3 commits into from
Oct 2, 2022
Merged

#156 Support torchmetrics #230

merged 3 commits into from
Oct 2, 2022

Conversation

Dref360
Copy link
Member

@Dref360 Dref360 commented Aug 27, 2022

Summary:

Add support for TorchMetric in ModelWrapper.

Features:

Fixes #156

Checklist:

  • Your code is documented (To validate this, add your module to tests/documentation_test.py).
  • Your code is tested with unit tests.
  • You moved your Issue to the PR state.

if filter in k:
if "loss" in k:
v.update(loss)
for met_name, metric in self.metrics.items():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, better naming :P

Copy link
Collaborator

@parmidaatg parmidaatg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@Dref360 Dref360 enabled auto-merge (squash) October 2, 2022 16:00
@Dref360 Dref360 merged commit deafffa into master Oct 2, 2022
@Dref360 Dref360 deleted the BAAL-156/torchmetrics branch October 2, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use torchmetrics in baal.metrics
2 participants