Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when data augmentation is applied on the pool #229

Merged
merged 11 commits into from
Oct 2, 2022

Conversation

Dref360
Copy link
Member

@Dref360 Dref360 commented Aug 20, 2022

Summary:

If users do not disable data augmentation, this will affect the uncertainty estimation which we do not want. We simply raise a warning.

Features:

Fixes #227

Checklist:

  • Your code is documented (To validate this, add your module to tests/documentation_test.py).
  • Your code is tested with unit tests.
  • You moved your Issue to the PR state.

Copy link
Collaborator

@parmidaatg parmidaatg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a rewording comment

baal/active/dataset/pytorch_dataset.py Outdated Show resolved Hide resolved
Co-authored-by: Parmida Atighehchian <parmidaatg@users.noreply.github.com>
@Dref360 Dref360 enabled auto-merge (squash) October 2, 2022 16:03
@Dref360 Dref360 merged commit 19fbbb4 into master Oct 2, 2022
@Dref360 Dref360 deleted the BAAL-227/da_check branch October 2, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate that data augmentation is disabled when running Active Learning Loop
2 participants