Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix ibc transfer from ethermint to external chain #11

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Jul 19, 2024

Closes: #XXX

Description

  • Fixes an issue that caused a nil pointer error when doing an ibc transfer to an external chain because the ibc's transfer keeper had an ics4 wrapper of nil when it was created.

how to test

  • check that ibc transfer from canto to external chain is performed well without panic

ref. b-harvest/Canto#71


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2 dudong2 self-assigned this Jul 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.30%. Comparing base (0712f94) to head (6d675de).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           canto-v8/develop      #11   +/-   ##
=================================================
  Coverage             68.30%   68.30%           
=================================================
  Files                   117      117           
  Lines                 11240    11240           
=================================================
  Hits                   7677     7677           
  Misses                 3088     3088           
  Partials                475      475           
Files Coverage Δ
app/app.go 85.27% <100.00%> (ø)

Copy link
Collaborator

@poorphd poorphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 changed the title bug: fix ibc transfer from canto to external chain bug: fix ibc transfer from ethermint to external chain Jul 29, 2024
@dudong2 dudong2 merged commit ba254fb into canto-v8/develop Jul 29, 2024
14 of 22 checks passed
@dudong2 dudong2 deleted the patch/fix-ibc branch July 29, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants