Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix ibc transfer from canto to external chain #71

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

dudong2
Copy link

@dudong2 dudong2 commented Jul 18, 2024

Description

  • Fixes an issue that caused a nil pointer error when doing an ibc transfer to an external chain because the ibc's transfer keeper had an ics4 wrapper of nil when it was created.

how to test

  • check that ibc transfer from canto to external chain is performed well without panic

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dudong2 dudong2 self-assigned this Jul 18, 2024
@dudong2 dudong2 requested review from dongsam and zsystm July 18, 2024 08:14
Copy link

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit c2369a0 into v8/develop Jul 18, 2024
8 checks passed
@dudong2 dudong2 deleted the patch/fix-ibc branch July 18, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants