Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove more type verification at runtime, and narrow down argument/return types #319

Merged
merged 1 commit into from
Dec 20, 2021
Merged

chore: remove more type verification at runtime, and narrow down argument/return types #319

merged 1 commit into from
Dec 20, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Dec 20, 2021

continues #317

@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. Type: BC Break A change that will result in a backward compatibility break in the public API. labels Dec 20, 2021
@azjezz azjezz added this to the 2.0.0 milestone Dec 20, 2021
@azjezz azjezz self-assigned this Dec 20, 2021
@coveralls
Copy link

coveralls commented Dec 20, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1603288214

  • 92 of 92 (100.0%) changed or added relevant lines in 26 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0006%) to 99.88%
Totals Coverage Status
Change from base Build 1599720516: 0.0006%
Covered Lines: 3332
Relevant Lines: 3336
💛 - Coveralls

@azjezz azjezz force-pushed the chore/remove-runtime-checks-2 branch 5 times, most recently from 0d501da to ddbe35f Compare December 20, 2021 17:37
@azjezz
chore: remove type verification at runtime
7b11f2c 
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz force-pushed the chore/remove-runtime-checks-2 branch from ddbe35f to 7b11f2c Compare December 20, 2021 17:48
@azjezz azjezz merged commit b5a77b6 into 2.0.x Dec 20, 2021
@azjezz azjezz deleted the chore/remove-runtime-checks-2 branch December 20, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: BC Break A change that will result in a backward compatibility break in the public API. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@azjezz @coveralls