-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filesystem - add argument values into InvariantViolationException message #205
Filesystem - add argument values into InvariantViolationException message #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this 👍
P.S: you can regenerate the docs using |
Pull Request Test Coverage Report for Build 903482522
💛 - Coveralls |
…ecessary Str\format call
I see inconsistency in input argument
is $file. I am not sure which is better. But I do not want to rename it in this PR. |
yea, i can see how that is confusing, we should rename $filename to $path or $node, as everywhere else it means "file or directory", while the functions you mentioned explicitly require a file, not a directory. |
Docs updated. I think I am done. |
make coding-standards-fix 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vaclavvanik!
ops, doc needs another update ( you can run checks locally using |
I have updated docs. Now should be everything ok. |
I mentioned in #204 that thrown
InvariantViolationException
messages should contain argument values. It's easier to debug and fix code.I updated everything I have found. Unit tests just updated. No additional unit tests added.